Re: [PATCH] spi: bcm2835: Implement shutdown callback

2020-05-29 Thread Florian Fainelli
On 5/29/20 10:58 AM, Lukas Wunner wrote: > On Fri, May 29, 2020 at 10:48:11AM -0700, Florian Fainelli wrote: >> On 5/29/20 10:47 AM, Lukas Wunner wrote: >>> On Thu, May 28, 2020 at 12:06:05PM -0700, Florian Fainelli wrote: Make sure we clear the FIFOs, stop the block, disable the clock and

Re: [PATCH] spi: bcm2835: Implement shutdown callback

2020-05-29 Thread Lukas Wunner
On Fri, May 29, 2020 at 10:48:11AM -0700, Florian Fainelli wrote: > On 5/29/20 10:47 AM, Lukas Wunner wrote: > > On Thu, May 28, 2020 at 12:06:05PM -0700, Florian Fainelli wrote: > >> Make sure we clear the FIFOs, stop the block, disable the clock and > >> release the DMA channel. > > > > To what

Re: [PATCH] spi: bcm2835: Implement shutdown callback

2020-05-29 Thread Florian Fainelli
On 5/29/20 10:47 AM, Lukas Wunner wrote: > On Thu, May 28, 2020 at 12:06:05PM -0700, Florian Fainelli wrote: >> Make sure we clear the FIFOs, stop the block, disable the clock and >> release the DMA channel. > > To what end? Why is this change necessary? Sorry but this seems like > an awfully

Re: [PATCH] spi: bcm2835: Implement shutdown callback

2020-05-29 Thread Lukas Wunner
On Thu, May 28, 2020 at 12:06:05PM -0700, Florian Fainelli wrote: > Make sure we clear the FIFOs, stop the block, disable the clock and > release the DMA channel. To what end? Why is this change necessary? Sorry but this seems like an awfully terse commit message. Thanks, Lukas > >

Re: [PATCH] spi: bcm2835: Implement shutdown callback

2020-05-29 Thread Mark Brown
On Thu, 28 May 2020 12:06:05 -0700, Florian Fainelli wrote: > Make sure we clear the FIFOs, stop the block, disable the clock and > release the DMA channel. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: bcm2835: Implement shutdown

[PATCH] spi: bcm2835: Implement shutdown callback

2020-05-28 Thread Florian Fainelli
Make sure we clear the FIFOs, stop the block, disable the clock and release the DMA channel. Signed-off-by: Florian Fainelli --- drivers/spi/spi-bcm2835.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c index