Re: [PATCH] spi: core: Increase timeout value

2014-04-11 Thread Mark Brown
On Fri, Apr 11, 2014 at 08:39:54AM +0530, Harini Katakam wrote: > On Thu, Apr 10, 2014 at 11:06 PM, Mark Brown wrote: > > Ideally we'd use the actual speed the device set rather than the > > requested one too, that'd help. > How would you propose to do that - driver should write back actual

Re: [PATCH] spi: core: Increase timeout value

2014-04-11 Thread Mark Brown
On Fri, Apr 11, 2014 at 08:39:54AM +0530, Harini Katakam wrote: On Thu, Apr 10, 2014 at 11:06 PM, Mark Brown broo...@kernel.org wrote: Ideally we'd use the actual speed the device set rather than the requested one too, that'd help. How would you propose to do that - driver should write

Re: [PATCH] spi: core: Increase timeout value

2014-04-10 Thread Harini Katakam
Hi Mark, On Thu, Apr 10, 2014 at 11:06 PM, Mark Brown wrote: > On Thu, Apr 10, 2014 at 06:20:29PM +0530, Harini Katakam wrote: > >> Considering acceptable latencies, this timeout can be set to a large >> value >= 1*HZ typically. > >> This patch adds a tolerance of 2000 msec in the core

Re: [PATCH] spi: core: Increase timeout value

2014-04-10 Thread Mark Brown
On Thu, Apr 10, 2014 at 06:20:29PM +0530, Harini Katakam wrote: > Considering acceptable latencies, this timeout can be set to a large > value >= 1*HZ typically. > This patch adds a tolerance of 2000 msec in the core accordingly. That's too much, it's 2 seconds which gets to be incredibly

[PATCH] spi: core: Increase timeout value

2014-04-10 Thread Harini Katakam
The existing timeout value in wait_for_completion_timeout is calculated from the transfer length and speed with tolerance of 10msec. This is too low because this is used for error conditions such as hardware hang etc. The xfer->speed_hz considered may not be the actual speed set because the best

[PATCH] spi: core: Increase timeout value

2014-04-10 Thread Harini Katakam
The existing timeout value in wait_for_completion_timeout is calculated from the transfer length and speed with tolerance of 10msec. This is too low because this is used for error conditions such as hardware hang etc. The xfer-speed_hz considered may not be the actual speed set because the best

Re: [PATCH] spi: core: Increase timeout value

2014-04-10 Thread Mark Brown
On Thu, Apr 10, 2014 at 06:20:29PM +0530, Harini Katakam wrote: Considering acceptable latencies, this timeout can be set to a large value = 1*HZ typically. This patch adds a tolerance of 2000 msec in the core accordingly. That's too much, it's 2 seconds which gets to be incredibly painful

Re: [PATCH] spi: core: Increase timeout value

2014-04-10 Thread Harini Katakam
Hi Mark, On Thu, Apr 10, 2014 at 11:06 PM, Mark Brown broo...@kernel.org wrote: On Thu, Apr 10, 2014 at 06:20:29PM +0530, Harini Katakam wrote: Considering acceptable latencies, this timeout can be set to a large value = 1*HZ typically. This patch adds a tolerance of 2000 msec in the core