Re: [PATCH] spi: core: Protect DMA code by #ifdef CONFIG_HAS_DMA

2014-05-02 Thread Mark Brown
On Fri, May 02, 2014 at 11:09:18PM +0200, Geert Uytterhoeven wrote: > On Fri, May 2, 2014 at 7:14 PM, Mark Brown wrote: > > Ugh. It would seem better to have these functions stubbed out. But > As long as we have include/asm-generic/dma-mapping-broken.h, > it'll be like this... Yeah, I'm not

Re: [PATCH] spi: core: Protect DMA code by #ifdef CONFIG_HAS_DMA

2014-05-02 Thread Geert Uytterhoeven
Hi Mark, On Fri, May 2, 2014 at 7:14 PM, Mark Brown wrote: > On Fri, May 02, 2014 at 06:29:34AM +0200, Geert Uytterhoeven wrote: >> If NO_DMA=y: >> >> drivers/built-in.o: In function `spi_map_buf': >> spi.c:(.text+0x21bc60): undefined reference to `dma_map_sg' >> drivers/built-in.o: In function

Re: [PATCH] spi: core: Protect DMA code by #ifdef CONFIG_HAS_DMA

2014-05-02 Thread Mark Brown
On Fri, May 02, 2014 at 06:29:34AM +0200, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `spi_map_buf': > spi.c:(.text+0x21bc60): undefined reference to `dma_map_sg' > drivers/built-in.o: In function `spi_unmap_buf.isra.33': > spi.c:(.text+0x21c32e): undefined

Re: [PATCH] spi: core: Protect DMA code by #ifdef CONFIG_HAS_DMA

2014-05-02 Thread Mark Brown
On Fri, May 02, 2014 at 06:29:34AM +0200, Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `spi_map_buf': spi.c:(.text+0x21bc60): undefined reference to `dma_map_sg' drivers/built-in.o: In function `spi_unmap_buf.isra.33': spi.c:(.text+0x21c32e): undefined reference to

Re: [PATCH] spi: core: Protect DMA code by #ifdef CONFIG_HAS_DMA

2014-05-02 Thread Geert Uytterhoeven
Hi Mark, On Fri, May 2, 2014 at 7:14 PM, Mark Brown broo...@kernel.org wrote: On Fri, May 02, 2014 at 06:29:34AM +0200, Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `spi_map_buf': spi.c:(.text+0x21bc60): undefined reference to `dma_map_sg' drivers/built-in.o: In

Re: [PATCH] spi: core: Protect DMA code by #ifdef CONFIG_HAS_DMA

2014-05-02 Thread Mark Brown
On Fri, May 02, 2014 at 11:09:18PM +0200, Geert Uytterhoeven wrote: On Fri, May 2, 2014 at 7:14 PM, Mark Brown broo...@kernel.org wrote: Ugh. It would seem better to have these functions stubbed out. But As long as we have include/asm-generic/dma-mapping-broken.h, it'll be like this...

[PATCH] spi: core: Protect DMA code by #ifdef CONFIG_HAS_DMA

2014-05-01 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `spi_map_buf': spi.c:(.text+0x21bc60): undefined reference to `dma_map_sg' drivers/built-in.o: In function `spi_unmap_buf.isra.33': spi.c:(.text+0x21c32e): undefined reference to `dma_unmap_sg' make[3]: *** [vmlinux] Error 1 Protect the DMA code by

[PATCH] spi: core: Protect DMA code by #ifdef CONFIG_HAS_DMA

2014-05-01 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `spi_map_buf': spi.c:(.text+0x21bc60): undefined reference to `dma_map_sg' drivers/built-in.o: In function `spi_unmap_buf.isra.33': spi.c:(.text+0x21c32e): undefined reference to `dma_unmap_sg' make[3]: *** [vmlinux] Error 1 Protect the DMA code by