Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-22 Thread Michael Welling
On Fri, May 22, 2015 at 01:25:44PM +0100, Mark Brown wrote: > On Thu, May 21, 2015 at 06:48:33PM -0500, Michael Welling wrote: > > > So after reverting this patch I found there is a issue in that it is > > difficult > > to determine when a transfer is complete to properly drive the chipselect >

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-22 Thread Mark Brown
On Thu, May 21, 2015 at 06:48:33PM -0500, Michael Welling wrote: > So after reverting this patch I found there is a issue in that it is difficult > to determine when a transfer is complete to properly drive the chipselect from > within the transfer_one function. Is unprepare_message() a suitable

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-22 Thread Mark Brown
On Thu, May 21, 2015 at 06:48:33PM -0500, Michael Welling wrote: So after reverting this patch I found there is a issue in that it is difficult to determine when a transfer is complete to properly drive the chipselect from within the transfer_one function. Is unprepare_message() a suitable

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-22 Thread Michael Welling
On Fri, May 22, 2015 at 01:25:44PM +0100, Mark Brown wrote: On Thu, May 21, 2015 at 06:48:33PM -0500, Michael Welling wrote: So after reverting this patch I found there is a issue in that it is difficult to determine when a transfer is complete to properly drive the chipselect from

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-21 Thread Michael Welling
On Thu, May 21, 2015 at 10:16:38PM +0100, Mark Brown wrote: > On Thu, May 21, 2015 at 04:04:11PM -0500, Michael Welling wrote: > > > Do you want to revert the patch and apply a new one or should I provide a > > patch that reverts the changes and fixes it all in one? > > Can you please send me

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-21 Thread Mark Brown
On Thu, May 21, 2015 at 04:04:11PM -0500, Michael Welling wrote: > Do you want to revert the patch and apply a new one or should I provide a > patch that reverts the changes and fixes it all in one? Can you please send me separate revert and re-add patches, that's probably going to be easier to

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-21 Thread Michael Welling
On Thu, May 21, 2015 at 11:18:57AM +0100, Mark Brown wrote: > On Wed, May 20, 2015 at 09:07:09PM -0500, Michael Welling wrote: > > > My guess is that the set_cs needs to be called even when toggling as GPIO. > > > How should I handle this? > > It shouldn't be part of a set_cs() operation but

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-21 Thread Mark Brown
On Wed, May 20, 2015 at 09:07:09PM -0500, Michael Welling wrote: > My guess is that the set_cs needs to be called even when toggling as GPIO. > How should I handle this? It shouldn't be part of a set_cs() operation but rather part of the main transfer operation. signature.asc Description:

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-21 Thread Mark Brown
On Thu, May 21, 2015 at 04:04:11PM -0500, Michael Welling wrote: Do you want to revert the patch and apply a new one or should I provide a patch that reverts the changes and fixes it all in one? Can you please send me separate revert and re-add patches, that's probably going to be easier to

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-21 Thread Michael Welling
On Thu, May 21, 2015 at 11:18:57AM +0100, Mark Brown wrote: On Wed, May 20, 2015 at 09:07:09PM -0500, Michael Welling wrote: My guess is that the set_cs needs to be called even when toggling as GPIO. How should I handle this? It shouldn't be part of a set_cs() operation but rather part

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-21 Thread Mark Brown
On Wed, May 20, 2015 at 09:07:09PM -0500, Michael Welling wrote: My guess is that the set_cs needs to be called even when toggling as GPIO. How should I handle this? It shouldn't be part of a set_cs() operation but rather part of the main transfer operation. signature.asc Description:

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-21 Thread Michael Welling
On Thu, May 21, 2015 at 10:16:38PM +0100, Mark Brown wrote: On Thu, May 21, 2015 at 04:04:11PM -0500, Michael Welling wrote: Do you want to revert the patch and apply a new one or should I provide a patch that reverts the changes and fixes it all in one? Can you please send me separate

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-20 Thread Michael Welling
On Tue, May 12, 2015 at 08:17:58PM +0100, Mark Brown wrote: > On Tue, May 12, 2015 at 12:38:57PM -0500, Michael Welling wrote: > > GPIO chip select patch series appears to have broken the native chip select > > support. This patch pulls the manual native chip select toggling out of > > the

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-20 Thread Michael Welling
On Tue, May 12, 2015 at 08:17:58PM +0100, Mark Brown wrote: On Tue, May 12, 2015 at 12:38:57PM -0500, Michael Welling wrote: GPIO chip select patch series appears to have broken the native chip select support. This patch pulls the manual native chip select toggling out of the transfer_one

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-12 Thread Mark Brown
On Tue, May 12, 2015 at 12:38:57PM -0500, Michael Welling wrote: > GPIO chip select patch series appears to have broken the native chip select > support. This patch pulls the manual native chip select toggling out of > the transfer_one routine and adds a set_cs routine. Applied, thanks

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-12 Thread Nishanth Menon
On 05/12/2015 02:19 PM, Mark Brown wrote: > On Tue, May 12, 2015 at 01:57:36PM -0500, Nishanth Menon wrote: >> On 05/12/2015 12:38 PM, Michael Welling wrote: >>> GPIO chip select patch series appears to have broken the native chip select >>> support. This patch pulls the manual native chip select

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-12 Thread Mark Brown
On Tue, May 12, 2015 at 01:57:36PM -0500, Nishanth Menon wrote: > On 05/12/2015 12:38 PM, Michael Welling wrote: > > GPIO chip select patch series appears to have broken the native chip select > > support. This patch pulls the manual native chip select toggling out of > > the transfer_one routine

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-12 Thread Nishanth Menon
On 05/12/2015 12:38 PM, Michael Welling wrote: > GPIO chip select patch series appears to have broken the native chip select > support. This patch pulls the manual native chip select toggling out of > the transfer_one routine and adds a set_cs routine. > > Tested natively on AM3354 with SPI

[PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-12 Thread Michael Welling
GPIO chip select patch series appears to have broken the native chip select support. This patch pulls the manual native chip select toggling out of the transfer_one routine and adds a set_cs routine. Tested natively on AM3354 with SPI serial flash on spi0cs0. Signed-off-by: Michael Welling ---

[PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-12 Thread Michael Welling
GPIO chip select patch series appears to have broken the native chip select support. This patch pulls the manual native chip select toggling out of the transfer_one routine and adds a set_cs routine. Tested natively on AM3354 with SPI serial flash on spi0cs0. Signed-off-by: Michael Welling

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-12 Thread Mark Brown
On Tue, May 12, 2015 at 12:38:57PM -0500, Michael Welling wrote: GPIO chip select patch series appears to have broken the native chip select support. This patch pulls the manual native chip select toggling out of the transfer_one routine and adds a set_cs routine. Applied, thanks

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-12 Thread Nishanth Menon
On 05/12/2015 02:19 PM, Mark Brown wrote: On Tue, May 12, 2015 at 01:57:36PM -0500, Nishanth Menon wrote: On 05/12/2015 12:38 PM, Michael Welling wrote: GPIO chip select patch series appears to have broken the native chip select support. This patch pulls the manual native chip select toggling

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-12 Thread Nishanth Menon
On 05/12/2015 12:38 PM, Michael Welling wrote: GPIO chip select patch series appears to have broken the native chip select support. This patch pulls the manual native chip select toggling out of the transfer_one routine and adds a set_cs routine. Tested natively on AM3354 with SPI serial

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-12 Thread Mark Brown
On Tue, May 12, 2015 at 01:57:36PM -0500, Nishanth Menon wrote: On 05/12/2015 12:38 PM, Michael Welling wrote: GPIO chip select patch series appears to have broken the native chip select support. This patch pulls the manual native chip select toggling out of the transfer_one routine and