Re: [PATCH] spi: spidev: Don't mangle max_speed_hz in underlying spi device

2014-11-11 Thread Mark Brown
On Tue, Nov 11, 2014 at 07:53:59AM -0600, Thor Thayer wrote: > Hi Mark, Please delete irrelevant context from mails, it makes it much easier to find any new content you've added. > On 11/08/2014 04:29 AM, Mark Brown wrote: > > if (retval < 0) > >-

Re: [PATCH] spi: spidev: Don't mangle max_speed_hz in underlying spi device

2014-11-11 Thread Thor Thayer
Hi Mark, On 11/08/2014 04:29 AM, Mark Brown wrote: Currently spidev allows callers to set the default speed by overriding the max_speed_hz in the underlying device. This achieves the immediate goal but is not what devices expect and can easily lead to userspace trying to set unsupported speeds

Re: [PATCH] spi: spidev: Don't mangle max_speed_hz in underlying spi device

2014-11-11 Thread Thor Thayer
Hi Mark, On 11/08/2014 04:29 AM, Mark Brown wrote: Currently spidev allows callers to set the default speed by overriding the max_speed_hz in the underlying device. This achieves the immediate goal but is not what devices expect and can easily lead to userspace trying to set unsupported speeds

Re: [PATCH] spi: spidev: Don't mangle max_speed_hz in underlying spi device

2014-11-11 Thread Mark Brown
On Tue, Nov 11, 2014 at 07:53:59AM -0600, Thor Thayer wrote: Hi Mark, Please delete irrelevant context from mails, it makes it much easier to find any new content you've added. On 11/08/2014 04:29 AM, Mark Brown wrote: if (retval 0) -

[PATCH] spi: spidev: Don't mangle max_speed_hz in underlying spi device

2014-11-08 Thread Mark Brown
Currently spidev allows callers to set the default speed by overriding the max_speed_hz in the underlying device. This achieves the immediate goal but is not what devices expect and can easily lead to userspace trying to set unsupported speeds and succeeding, apart from anything else drivers can't

[PATCH] spi: spidev: Don't mangle max_speed_hz in underlying spi device

2014-11-08 Thread Mark Brown
Currently spidev allows callers to set the default speed by overriding the max_speed_hz in the underlying device. This achieves the immediate goal but is not what devices expect and can easily lead to userspace trying to set unsupported speeds and succeeding, apart from anything else drivers can't