Re: [PATCH] staging/android: mark sync_timeline_create() static

2016-09-12 Thread Greg KH
On Mon, Sep 05, 2016 at 08:40:25AM +0800, Baoyou Xie wrote: > > > On 4 September 2016 at 23:41, Sudip Mukherjee > wrote: > > On Sat, Sep 03, 2016 at 02:34:13PM +0800, Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > >

Re: [PATCH] staging/android: mark sync_timeline_create() static

2016-09-12 Thread Greg KH
On Mon, Sep 05, 2016 at 08:40:25AM +0800, Baoyou Xie wrote: > > > On 4 September 2016 at 23:41, Sudip Mukherjee > wrote: > > On Sat, Sep 03, 2016 at 02:34:13PM +0800, Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > > drivers/staging/android/sw_sync.c:56:23:

Re: [PATCH] staging/android: mark sync_timeline_create() static

2016-09-04 Thread Sudip Mukherjee
On Sat, Sep 03, 2016 at 02:34:13PM +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/staging/android/sw_sync.c:56:23: warning: no previous prototype for > 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which

Re: [PATCH] staging/android: mark sync_timeline_create() static

2016-09-04 Thread Sudip Mukherjee
On Sat, Sep 03, 2016 at 02:34:13PM +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/staging/android/sw_sync.c:56:23: warning: no previous prototype for > 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which

[PATCH] staging/android: mark sync_timeline_create() static

2016-09-03 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/staging/android/sw_sync.c:56:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static.

[PATCH] staging/android: mark sync_timeline_create() static

2016-09-03 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/staging/android/sw_sync.c:56:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static.