Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-25 Thread Sergei Shtylyov
Hello. On 03/25/2014 02:12 AM, Shuah Khan wrote: Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 Please also specify that commit's summary line in parens. Also, there's now an established format for such things: Fixes: <12-digit SHA ID> ("") You can place such line before

Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-25 Thread Sergei Shtylyov
Hello. On 03/25/2014 02:12 AM, Shuah Khan wrote: Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 Please also specify that commit's summary line in parens. Also, there's now an established format for such things: Fixes: 12-digit SHA ID (summary line) You can place such line

Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-24 Thread Shuah Khan
On 03/24/2014 06:38 PM, Greg KH wrote: On Mon, Mar 24, 2014 at 05:12:09PM -0600, Shuah Khan wrote: Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 What do you mean by this line? Nothing really. Sloppiness on my part. I was keeping notes as I was chasing the problem and those ended

Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-24 Thread Greg KH
On Mon, Mar 24, 2014 at 05:12:09PM -0600, Shuah Khan wrote: > Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 What do you mean by this line? > This commit added return value check for sscanf() that parses the > input buffer for four input items. However, the return value check > is

[PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-24 Thread Shuah Khan
Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 This commit added return value check for sscanf() that parses the input buffer for four input items. However, the return value check is incorrect, as it checks for one input item instead of four which is what it is expecting in the input

[PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-24 Thread Shuah Khan
Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 This commit added return value check for sscanf() that parses the input buffer for four input items. However, the return value check is incorrect, as it checks for one input item instead of four which is what it is expecting in the input

Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-24 Thread Greg KH
On Mon, Mar 24, 2014 at 05:12:09PM -0600, Shuah Khan wrote: Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 What do you mean by this line? This commit added return value check for sscanf() that parses the input buffer for four input items. However, the return value check is incorrect,

Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-24 Thread Shuah Khan
On 03/24/2014 06:38 PM, Greg KH wrote: On Mon, Mar 24, 2014 at 05:12:09PM -0600, Shuah Khan wrote: Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 What do you mean by this line? Nothing really. Sloppiness on my part. I was keeping notes as I was chasing the problem and those ended