Re: [PATCH] staging: comedi: dt2801: change function return type to void

2014-08-18 Thread Ian Abbott
On 2014-08-18 04:43, Chase Southwood wrote: cppcheck was complaining that the variable 'stat' is being reassigned before the old value is used. Upon inspection, I found that dt2801_writecmd() cannot fail, always returns 0, and most callers already do not bother with assigning its return value

Re: [PATCH] staging: comedi: dt2801: change function return type to void

2014-08-18 Thread Ian Abbott
On 2014-08-18 04:43, Chase Southwood wrote: cppcheck was complaining that the variable 'stat' is being reassigned before the old value is used. Upon inspection, I found that dt2801_writecmd() cannot fail, always returns 0, and most callers already do not bother with assigning its return value

[PATCH] staging: comedi: dt2801: change function return type to void

2014-08-17 Thread Chase Southwood
cppcheck was complaining that the variable 'stat' is being reassigned before the old value is used. Upon inspection, I found that dt2801_writecmd() cannot fail, always returns 0, and most callers already do not bother with assigning its return value anyway, so it makes sense to just change the

[PATCH] staging: comedi: dt2801: change function return type to void

2014-08-17 Thread Chase Southwood
cppcheck was complaining that the variable 'stat' is being reassigned before the old value is used. Upon inspection, I found that dt2801_writecmd() cannot fail, always returns 0, and most callers already do not bother with assigning its return value anyway, so it makes sense to just change the