Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-05-17 Thread DaeSeok Youn
2014-05-17 8:09 GMT+09:00, Greg KH : > On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote: >> - alloc_tty_driver() is deprecated so it is changed to >> tty_alloc_driver() >> - Pointers which are allocated by alloc_tty_driver() and kzalloc() >> can be NULL so it need to check NULL for

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-05-17 Thread DaeSeok Youn
2014-05-17 8:09 GMT+09:00, Greg KH gre...@linuxfoundation.org: On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote: - alloc_tty_driver() is deprecated so it is changed to tty_alloc_driver() - Pointers which are allocated by alloc_tty_driver() and kzalloc() can be NULL so it need to

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-05-16 Thread Greg KH
On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote: > - alloc_tty_driver() is deprecated so it is changed to > tty_alloc_driver() > - Pointers which are allocated by alloc_tty_driver() and kzalloc() > can be NULL so it need to check NULL for them. > - If one of those is failed, it need

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-05-16 Thread Greg KH
On Fri, May 16, 2014 at 12:52:47PM +0300, Dan Carpenter wrote: > On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote: > > Hi, > > > > This patch haven't been updated over the past 3 weeks. > > Will you check for me? > > Greg was trying to travel around the world in one month like

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-05-16 Thread DaeSeok Youn
2014-05-16 18:52 GMT+09:00 Dan Carpenter : > On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote: >> Hi, >> >> This patch haven't been updated over the past 3 weeks. >> Will you check for me? > > Greg was trying to travel around the world in one month like Jackie > Chan.

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-05-16 Thread Dan Carpenter
On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote: > Hi, > > This patch haven't been updated over the past 3 weeks. > Will you check for me? Greg was trying to travel around the world in one month like Jackie Chan. http://www.imdb.com/title/tt0327437/ He is back to work since

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-05-16 Thread DaeSeok Youn
Hi, This patch haven't been updated over the past 3 weeks. Will you check for me? Regards, Daeseok Youn. 2014-04-28 8:21 GMT+09:00 DaeSeok Youn : > OK. I'll make my patch based on Mark's patch. > Thanks. > > Daeseok Youn. > > 2014-04-27 3:48 GMT+09:00 Dan Carpenter : >> On Sat, Apr 26, 2014

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-05-16 Thread DaeSeok Youn
Hi, This patch haven't been updated over the past 3 weeks. Will you check for me? Regards, Daeseok Youn. 2014-04-28 8:21 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com: OK. I'll make my patch based on Mark's patch. Thanks. Daeseok Youn. 2014-04-27 3:48 GMT+09:00 Dan Carpenter

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-05-16 Thread Dan Carpenter
On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote: Hi, This patch haven't been updated over the past 3 weeks. Will you check for me? Greg was trying to travel around the world in one month like Jackie Chan. http://www.imdb.com/title/tt0327437/ He is back to work since

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-05-16 Thread DaeSeok Youn
2014-05-16 18:52 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote: Hi, This patch haven't been updated over the past 3 weeks. Will you check for me? Greg was trying to travel around the world in one month like Jackie Chan.

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-05-16 Thread Greg KH
On Fri, May 16, 2014 at 12:52:47PM +0300, Dan Carpenter wrote: On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote: Hi, This patch haven't been updated over the past 3 weeks. Will you check for me? Greg was trying to travel around the world in one month like Jackie Chan.

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-05-16 Thread Greg KH
On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote: - alloc_tty_driver() is deprecated so it is changed to tty_alloc_driver() - Pointers which are allocated by alloc_tty_driver() and kzalloc() can be NULL so it need to check NULL for them. - If one of those is failed, it need to add

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-27 Thread DaeSeok Youn
OK. I'll make my patch based on Mark's patch. Thanks. Daeseok Youn. 2014-04-27 3:48 GMT+09:00 Dan Carpenter : > On Sat, Apr 26, 2014 at 11:39:38AM +0900, DaeSeok Youn wrote: >> Hi, >> >> please check below my comments. >> >> 2014-04-25 23:41 GMT+09:00 Mark Hounschell : >> > On 04/25/2014 08:59

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-27 Thread DaeSeok Youn
OK. I'll make my patch based on Mark's patch. Thanks. Daeseok Youn. 2014-04-27 3:48 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Sat, Apr 26, 2014 at 11:39:38AM +0900, DaeSeok Youn wrote: Hi, please check below my comments. 2014-04-25 23:41 GMT+09:00 Mark Hounschell

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-26 Thread Dan Carpenter
On Sat, Apr 26, 2014 at 11:39:38AM +0900, DaeSeok Youn wrote: > Hi, > > please check below my comments. > > 2014-04-25 23:41 GMT+09:00 Mark Hounschell : > > On 04/25/2014 08:59 AM, Dan Carpenter wrote: > >> On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote: > >>> On 04/25/2014

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-26 Thread Dan Carpenter
On Sat, Apr 26, 2014 at 11:39:38AM +0900, DaeSeok Youn wrote: Hi, please check below my comments. 2014-04-25 23:41 GMT+09:00 Mark Hounschell ma...@compro.net: On 04/25/2014 08:59 AM, Dan Carpenter wrote: On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote: On 04/25/2014

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread DaeSeok Youn
Hi, please check below my comments. 2014-04-25 23:41 GMT+09:00 Mark Hounschell : > On 04/25/2014 08:59 AM, Dan Carpenter wrote: >> On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote: >>> On 04/25/2014 07:02 AM, DaeSeok Youn wrote: Hi, Dan. 2014-04-25 18:26 GMT+09:00

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread Mark Hounschell
On 04/25/2014 08:59 AM, Dan Carpenter wrote: > On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote: >> On 04/25/2014 07:02 AM, DaeSeok Youn wrote: >>> Hi, Dan. >>> >>> 2014-04-25 18:26 GMT+09:00 Dan Carpenter : Mark, maybe you should add yourself to the MAINTAINERS entry for this

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread Dan Carpenter
On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote: > On 04/25/2014 07:02 AM, DaeSeok Youn wrote: > > Hi, Dan. > > > > 2014-04-25 18:26 GMT+09:00 Dan Carpenter : > >> Mark, maybe you should add yourself to the MAINTAINERS entry for this > >> driver? > >> > > I'll look into this. I

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread Mark Hounschell
On 04/25/2014 07:02 AM, DaeSeok Youn wrote: > Hi, Dan. > > 2014-04-25 18:26 GMT+09:00 Dan Carpenter : >> Mark, maybe you should add yourself to the MAINTAINERS entry for this >> driver? >> I'll look into this. I am clueless on what that would actually mean. >> On Fri, Apr 25, 2014 at 04:04:59PM

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread DaeSeok Youn
Hi, Dan. 2014-04-25 18:26 GMT+09:00 Dan Carpenter : > Mark, maybe you should add yourself to the MAINTAINERS entry for this > driver? > > On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote: >> @@ -1263,7 +1277,8 @@ static int dgap_tty_register(struct board_t *brd) >> /*

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread Dan Carpenter
Mark, maybe you should add yourself to the MAINTAINERS entry for this driver? On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote: > @@ -1263,7 +1277,8 @@ static int dgap_tty_register(struct board_t *brd) > /* Register tty devices */ > rc =

[PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread Daeseok Youn
- alloc_tty_driver() is deprecated so it is changed to tty_alloc_driver() - Pointers which are allocated by alloc_tty_driver() and kzalloc() can be NULL so it need to check NULL for them. - If one of those is failed, it need to add proper handler for avoiding memory leak. Signed-off-by: Daeseok

[PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread Daeseok Youn
- alloc_tty_driver() is deprecated so it is changed to tty_alloc_driver() - Pointers which are allocated by alloc_tty_driver() and kzalloc() can be NULL so it need to check NULL for them. - If one of those is failed, it need to add proper handler for avoiding memory leak. Signed-off-by: Daeseok

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread Dan Carpenter
Mark, maybe you should add yourself to the MAINTAINERS entry for this driver? On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote: @@ -1263,7 +1277,8 @@ static int dgap_tty_register(struct board_t *brd) /* Register tty devices */ rc =

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread DaeSeok Youn
Hi, Dan. 2014-04-25 18:26 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: Mark, maybe you should add yourself to the MAINTAINERS entry for this driver? On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote: @@ -1263,7 +1277,8 @@ static int dgap_tty_register(struct board_t *brd)

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread Mark Hounschell
On 04/25/2014 07:02 AM, DaeSeok Youn wrote: Hi, Dan. 2014-04-25 18:26 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: Mark, maybe you should add yourself to the MAINTAINERS entry for this driver? I'll look into this. I am clueless on what that would actually mean. On Fri, Apr 25, 2014

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread Dan Carpenter
On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote: On 04/25/2014 07:02 AM, DaeSeok Youn wrote: Hi, Dan. 2014-04-25 18:26 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: Mark, maybe you should add yourself to the MAINTAINERS entry for this driver? I'll look into

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread Mark Hounschell
On 04/25/2014 08:59 AM, Dan Carpenter wrote: On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote: On 04/25/2014 07:02 AM, DaeSeok Youn wrote: Hi, Dan. 2014-04-25 18:26 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: Mark, maybe you should add yourself to the MAINTAINERS entry

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-25 Thread DaeSeok Youn
Hi, please check below my comments. 2014-04-25 23:41 GMT+09:00 Mark Hounschell ma...@compro.net: On 04/25/2014 08:59 AM, Dan Carpenter wrote: On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote: On 04/25/2014 07:02 AM, DaeSeok Youn wrote: Hi, Dan. 2014-04-25 18:26 GMT+09:00 Dan