Re: [PATCH] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep()

2014-09-16 Thread Joe Perches
On Tue, 2014-09-16 at 09:31 +0300, Dan Carpenter wrote: > There is no point in calling signal_pending() if you don't care about > the return value. So maybe make it __must_check? --- include/linux/sched.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/sched.h

Re: [PATCH] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep()

2014-09-16 Thread DaeSeok Youn
Hi, 2014-09-16 15:31 GMT+09:00 Dan Carpenter : > > On Tue, Sep 16, 2014 at 12:33:33PM +0900, Daeseok Youn wrote: > > @@ -2297,12 +2273,12 @@ static void dgap_tty_close(struct tty_struct *tty, > > struct file *file) > >* Go to sleep to ensure RTS/DTR > >

Re: [PATCH] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep()

2014-09-16 Thread Dan Carpenter
On Tue, Sep 16, 2014 at 12:33:33PM +0900, Daeseok Youn wrote: > @@ -2297,12 +2273,12 @@ static void dgap_tty_close(struct tty_struct *tty, > struct file *file) >* Go to sleep to ensure RTS/DTR >* have been dropped for modems to see it. >

Re: [PATCH] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep()

2014-09-16 Thread Dan Carpenter
On Tue, Sep 16, 2014 at 12:33:33PM +0900, Daeseok Youn wrote: @@ -2297,12 +2273,12 @@ static void dgap_tty_close(struct tty_struct *tty, struct file *file) * Go to sleep to ensure RTS/DTR * have been dropped for modems to see it.

Re: [PATCH] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep()

2014-09-16 Thread DaeSeok Youn
Hi, 2014-09-16 15:31 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Tue, Sep 16, 2014 at 12:33:33PM +0900, Daeseok Youn wrote: @@ -2297,12 +2273,12 @@ static void dgap_tty_close(struct tty_struct *tty, struct file *file) * Go to sleep to ensure RTS/DTR

Re: [PATCH] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep()

2014-09-16 Thread Joe Perches
On Tue, 2014-09-16 at 09:31 +0300, Dan Carpenter wrote: There is no point in calling signal_pending() if you don't care about the return value. So maybe make it __must_check? --- include/linux/sched.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/sched.h

[PATCH] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep()

2014-09-15 Thread Daeseok Youn
Using schedule_timeout_interruptible() is exactly same as setting a status of current process and calling schedule_timeout(). Removes dgap_ms_sleep(), because this function is used only when closing tty channel on dgap_tty_close(). And also removes ch_close_delay that is always set to 250 on

[PATCH] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep()

2014-09-15 Thread Daeseok Youn
Using schedule_timeout_interruptible() is exactly same as setting a status of current process and calling schedule_timeout(). Removes dgap_ms_sleep(), because this function is used only when closing tty channel on dgap_tty_close(). And also removes ch_close_delay that is always set to 250 on