Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-05 Thread Dan Carpenter
On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > For the first lines of the patch, I opted to create a small function > instead of breaking the the line in a weird way. These first ones are the nice. > @@ -2511,13 +2516,15 @@ static int dgnc_tty_ioctl(struct tty_struct

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-05 Thread Dan Carpenter
On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > For the first lines of the patch, I opted to create a small function > instead of breaking the the line in a weird way. These first ones are the nice. > @@ -2511,13 +2516,15 @@ static int dgnc_tty_ioctl(struct tty_struct

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-04 Thread Fernando Apesteguia
On Sat, Dec 03, 2016 at 11:11:23AM +0100, Greg KH wrote: > On Sat, Dec 03, 2016 at 10:56:54AM +0100, Fernando Apesteguia wrote: > > On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > > > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > > > For the first lines of the

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-04 Thread Fernando Apesteguia
On Sat, Dec 03, 2016 at 11:11:23AM +0100, Greg KH wrote: > On Sat, Dec 03, 2016 at 10:56:54AM +0100, Fernando Apesteguia wrote: > > On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > > > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > > > For the first lines of the

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-03 Thread Fernando Apesteguia
On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > For the first lines of the patch, I opted to create a small function > > instead of breaking the the line in a weird way. > > > > The other changes are simple ones.

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-03 Thread Fernando Apesteguia
On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > For the first lines of the patch, I opted to create a small function > > instead of breaking the the line in a weird way. > > > > The other changes are simple ones.

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-03 Thread Greg KH
On Sat, Dec 03, 2016 at 10:56:54AM +0100, Fernando Apesteguia wrote: > On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > > For the first lines of the patch, I opted to create a small function > > > instead of

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-03 Thread Greg KH
On Sat, Dec 03, 2016 at 10:56:54AM +0100, Fernando Apesteguia wrote: > On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > > For the first lines of the patch, I opted to create a small function > > > instead of

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-03 Thread Greg KH
On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > For the first lines of the patch, I opted to create a small function > instead of breaking the the line in a weird way. > > The other changes are simple ones. > > Signed-off-by: Fernando Apesteguia

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-03 Thread Greg KH
On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > For the first lines of the patch, I opted to create a small function > instead of breaking the the line in a weird way. > > The other changes are simple ones. > > Signed-off-by: Fernando Apesteguia > --- >

[PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-02 Thread Fernando Apesteguia
For the first lines of the patch, I opted to create a small function instead of breaking the the line in a weird way. The other changes are simple ones. Signed-off-by: Fernando Apesteguia --- drivers/staging/dgnc/dgnc_tty.c | 42

[PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-02 Thread Fernando Apesteguia
For the first lines of the patch, I opted to create a small function instead of breaking the the line in a weird way. The other changes are simple ones. Signed-off-by: Fernando Apesteguia --- drivers/staging/dgnc/dgnc_tty.c | 42 + 1 file changed, 26

[PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-09-28 Thread Fernando Apesteguia
All the chunks of the patch apply to comments save the first one. Signed-off-by: Fernando Apesteguia --- drivers/staging/dgnc/dgnc_neo.c | 67 - 1 file changed, 46 insertions(+), 21 deletions(-) diff --git

[PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-09-28 Thread Fernando Apesteguia
All the chunks of the patch apply to comments save the first one. Signed-off-by: Fernando Apesteguia --- drivers/staging/dgnc/dgnc_neo.c | 67 - 1 file changed, 46 insertions(+), 21 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c