Re: [PATCH] staging: dgrp: dgrp_tty.c: return an -EFAULT if get_user() fails

2012-11-14 Thread Alan Cox
On Wed, 14 Nov 2012 13:11:18 +0530 Kumar Amit Mehta wrote: > Inspect the return value of get_user() and return -EFAULT on error. You cam just delete all the TIOCSOFTCAR nonsense. That ioctl is handled correctly by the core tty layer code rather than incorrectly by the dgrp driver. Alan -- To

[PATCH] staging: dgrp: dgrp_tty.c: return an -EFAULT if get_user() fails

2012-11-14 Thread Kumar Amit Mehta
Inspect the return value of get_user() and return -EFAULT on error. Signed-off-by: Kumar Amit Mehta --- drivers/staging/dgrp/dgrp_tty.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgrp/dgrp_tty.c b/drivers/staging/dgrp/dgrp_tty.c index

[PATCH] staging: dgrp: dgrp_tty.c: return an -EFAULT if get_user() fails

2012-11-14 Thread Kumar Amit Mehta
Inspect the return value of get_user() and return -EFAULT on error. Signed-off-by: Kumar Amit Mehta gmate.a...@gmail.com --- drivers/staging/dgrp/dgrp_tty.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgrp/dgrp_tty.c

Re: [PATCH] staging: dgrp: dgrp_tty.c: return an -EFAULT if get_user() fails

2012-11-14 Thread Alan Cox
On Wed, 14 Nov 2012 13:11:18 +0530 Kumar Amit Mehta gmate.a...@gmail.com wrote: Inspect the return value of get_user() and return -EFAULT on error. You cam just delete all the TIOCSOFTCAR nonsense. That ioctl is handled correctly by the core tty layer code rather than incorrectly by the dgrp