Re: [PATCH] staging: erofs: Add braces to do-while statements

2018-12-09 Thread Luc Van Oostenryck
On Sun, Dec 09, 2018 at 08:40:29PM +0100, Greg KH wrote: > On Sun, Dec 09, 2018 at 09:27:01AM -0800, Joe Perches wrote: > > On Sun, 2018-12-09 at 17:20 +0100, Greg KH wrote: > > > On Sun, Dec 09, 2018 at 04:59:00PM +0100, Thomas Jespersen wrote: > > > > This fixes warning reported by sparse (with

Re: [PATCH] staging: erofs: Add braces to do-while statements

2018-12-09 Thread Gao Xiang
[oops... I found Thomas sent the exactly the same email again.] On 2018/12/9 23:59, Thomas Jespersen wrote: > This fixes warning reported by sparse (with -Wsparse-all). > > Signed-off-by: Thomas Jespersen > --- > drivers/staging/erofs/internal.h | 4 ++-- > drivers/staging/erofs/utils.c| 4

Re: [PATCH] staging: erofs: Add braces to do-while statements

2018-12-09 Thread Greg KH
On Sun, Dec 09, 2018 at 09:27:01AM -0800, Joe Perches wrote: > On Sun, 2018-12-09 at 17:20 +0100, Greg KH wrote: > > On Sun, Dec 09, 2018 at 04:59:00PM +0100, Thomas Jespersen wrote: > > > This fixes warning reported by sparse (with -Wsparse-all). > > > > Why is sparse warning about this? > >

Re: [PATCH] staging: erofs: Add braces to do-while statements

2018-12-09 Thread Joe Perches
(mrph. premature send) On Sun, 2018-12-09 at 17:20 +0100, Greg KH wrote: > On Sun, Dec 09, 2018 at 04:59:00PM +0100, Thomas Jespersen wrote: > > This fixes warning reported by sparse (with -Wsparse-all). > > Why is sparse warning about this? Probably because it's the kernel preferred style to

Re: [PATCH] staging: erofs: Add braces to do-while statements

2018-12-09 Thread Joe Perches
On Sun, 2018-12-09 at 17:20 +0100, Greg KH wrote: > On Sun, Dec 09, 2018 at 04:59:00PM +0100, Thomas Jespersen wrote: > > This fixes warning reported by sparse (with -Wsparse-all). > > Why is sparse warning about this? Probably because it's the kernel preferred style to use single statement

Re: [PATCH] staging: erofs: Add braces to do-while statements

2018-12-09 Thread Greg KH
On Sun, Dec 09, 2018 at 04:59:00PM +0100, Thomas Jespersen wrote: > This fixes warning reported by sparse (with -Wsparse-all). Why is sparse warning about this? > Signed-off-by: Thomas Jespersen > --- > drivers/staging/erofs/internal.h | 4 ++-- > drivers/staging/erofs/utils.c| 4 ++-- > 2

[PATCH] staging: erofs: Add braces to do-while statements

2018-12-09 Thread Thomas Jespersen
This fixes warning reported by sparse (with -Wsparse-all). Signed-off-by: Thomas Jespersen --- drivers/staging/erofs/internal.h | 4 ++-- drivers/staging/erofs/utils.c| 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/erofs/internal.h