Re: [PATCH] staging: exfat: use bdev_sync function directly where needed

2019-10-03 Thread Dan Carpenter
Or we could apply your other patch which trumps both this patch and the patch to the TODO. regards, dan carpenter

Re: [PATCH] staging: exfat: use bdev_sync function directly where needed

2019-10-03 Thread Dan Carpenter
I replied to your other thread and I added Saiyam Doshi to the CC list there. Just to be clear this patch is a good cleanup and doesn't affect runtime at all. In the other thread, I suggested that we leave fs_sync() as a marker even though it's dead code. But looking at it now, I think that

Re: [PATCH] staging: exfat: use bdev_sync function directly where needed

2019-10-03 Thread Dan Carpenter
On Wed, Oct 02, 2019 at 08:47:03PM +0530, Saiyam Doshi wrote: > fs_sync() is wrapper to bdev_sync(). When fs_sync is called with > non-zero argument, bdev_sync gets called. > > Most instances of fs_sync is called with false and very few with > true. Refactor this and makes direct call to

Re: [PATCH] staging: exfat: use bdev_sync function directly where needed

2019-10-02 Thread Valdis Klētnieks
On Wed, 02 Oct 2019 20:47:03 +0530, Saiyam Doshi said: > fs_sync() is wrapper to bdev_sync(). When fs_sync is called with > non-zero argument, bdev_sync gets called. > > Most instances of fs_sync is called with false and very few with > true. Refactor this and makes direct call to bdev_sync()

[PATCH] staging: exfat: use bdev_sync function directly where needed

2019-10-02 Thread Saiyam Doshi
fs_sync() is wrapper to bdev_sync(). When fs_sync is called with non-zero argument, bdev_sync gets called. Most instances of fs_sync is called with false and very few with true. Refactor this and makes direct call to bdev_sync() where needed and removes fs_sync definition. Signed-off-by: Saiyam