[PATCH] staging: fwserial: Fix error handling in fwserial_create

[Dinghao Liu]

When fw_core_add_address_handler() fails, we need to destroy
the port by tty_port_destroy(). Also we need to unregister
the address handler by fw_core_remove_address_handler() on
failure.

Signed-off-by: Dinghao Liu <dinghao....@zju.edu.cn>
---
 drivers/staging/fwserial/fwserial.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/fwserial/fwserial.c 
b/drivers/staging/fwserial/fwserial.c
index db83d34cd677..c368082aae1a 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -2189,6 +2189,7 @@ static int fwserial_create(struct fw_unit *unit)
                err = fw_core_add_address_handler(&port->rx_handler,
                                                  &fw_high_memory_region);
                if (err) {
+                       tty_port_destroy(&port->port);
                        kfree(port);
                        goto free_ports;
                }
@@ -2271,6 +2272,7 @@ static int fwserial_create(struct fw_unit *unit)
 
 free_ports:
        for (--i; i >= 0; --i) {
+               fw_core_remove_address_handler(&serial->ports[i]->rx_handler);
                tty_port_destroy(&serial->ports[i]->port);
                kfree(serial->ports[i]);
        }
-- 
2.17.1