Re: [PATCH] staging: gdm724x: add error handling for nlmsg_put

2018-06-14 Thread Dan Carpenter
Also I think the email list is rejecting your replies because they're in html? regards, dan carpenter

Re: [PATCH] staging: gdm724x: add error handling for nlmsg_put

2018-06-14 Thread Dan Carpenter
Also I think the email list is rejecting your replies because they're in html? regards, dan carpenter

Re: [PATCH] staging: gdm724x: add error handling for nlmsg_put

2018-06-14 Thread Dan Carpenter
On Thu, Jun 14, 2018 at 11:27:26AM +0800, Zhouyang Jia wrote: > Hi, > > I reported this bug since more than 95% callsites of nlmsg_put are > well handled in kernel, and many of them also allocated skb before. > That's probably true, but the NULL check is not required *here*. Just mark it as a

Re: [PATCH] staging: gdm724x: add error handling for nlmsg_put

2018-06-14 Thread Dan Carpenter
On Thu, Jun 14, 2018 at 11:27:26AM +0800, Zhouyang Jia wrote: > Hi, > > I reported this bug since more than 95% callsites of nlmsg_put are > well handled in kernel, and many of them also allocated skb before. > That's probably true, but the NULL check is not required *here*. Just mark it as a

Re: [PATCH] staging: gdm724x: add error handling for nlmsg_put

2018-06-12 Thread Dan Carpenter
On Mon, Jun 11, 2018 at 01:09:24PM +0800, Zhouyang Jia wrote: > When nlmsg_put fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling nlmsg_put. > > Signed-off-by: Zhouyang Jia > --- > drivers/staging/gdm724x/netlink_k.c | 3

Re: [PATCH] staging: gdm724x: add error handling for nlmsg_put

2018-06-12 Thread Dan Carpenter
On Mon, Jun 11, 2018 at 01:09:24PM +0800, Zhouyang Jia wrote: > When nlmsg_put fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling nlmsg_put. > > Signed-off-by: Zhouyang Jia > --- > drivers/staging/gdm724x/netlink_k.c | 3

[PATCH] staging: gdm724x: add error handling for nlmsg_put

2018-06-10 Thread Zhouyang Jia
When nlmsg_put fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling nlmsg_put. Signed-off-by: Zhouyang Jia --- drivers/staging/gdm724x/netlink_k.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH] staging: gdm724x: add error handling for nlmsg_put

2018-06-10 Thread Zhouyang Jia
When nlmsg_put fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling nlmsg_put. Signed-off-by: Zhouyang Jia --- drivers/staging/gdm724x/netlink_k.c | 3 +++ 1 file changed, 3 insertions(+) diff --git