Re: [PATCH] staging: gdm724x: fix coding style issues

2015-01-03 Thread Ning Zhou
OK, then this one is abandoned. I will send two patches instead. /Ning On 2015-01-04 02:27, Konrad Zapalowicz wrote: > On 01/03, Ning Zhou wrote: >> Signed-off-by: Ning Zhou > > You need to describe your changes, a vague subject is not enough. Also > keep in mind that one patch shall address

Re: [PATCH] staging: gdm724x: fix coding style issues

2015-01-03 Thread Konrad Zapalowicz
On 01/03, Ning Zhou wrote: > Signed-off-by: Ning Zhou You need to describe your changes, a vague subject is not enough. Also keep in mind that one patch shall address one category of stuff and seems that yours could be separated into two. thanks, konrad > --- >

[PATCH] staging: gdm724x: fix coding style issues

2015-01-03 Thread Ning Zhou
Signed-off-by: Ning Zhou --- drivers/staging/gdm724x/gdm_lte.c | 3 ++- drivers/staging/gdm724x/gdm_mux.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c index 73eede1..7c4a77b 100644 ---

[PATCH] staging: gdm724x: fix coding style issues

2015-01-03 Thread Ning Zhou
Signed-off-by: Ning Zhou zhou.ning...@gmail.com --- drivers/staging/gdm724x/gdm_lte.c | 3 ++- drivers/staging/gdm724x/gdm_mux.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c index 73eede1..7c4a77b

Re: [PATCH] staging: gdm724x: fix coding style issues

2015-01-03 Thread Konrad Zapalowicz
On 01/03, Ning Zhou wrote: Signed-off-by: Ning Zhou zhou.ning...@gmail.com You need to describe your changes, a vague subject is not enough. Also keep in mind that one patch shall address one category of stuff and seems that yours could be separated into two. thanks, konrad ---

Re: [PATCH] staging: gdm724x: fix coding style issues

2015-01-03 Thread Ning Zhou
OK, then this one is abandoned. I will send two patches instead. /Ning On 2015-01-04 02:27, Konrad Zapalowicz wrote: On 01/03, Ning Zhou wrote: Signed-off-by: Ning Zhou zhou.ning...@gmail.com You need to describe your changes, a vague subject is not enough. Also keep in mind that one patch