Re: [PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

2014-11-18 Thread Greg KH
On Mon, Nov 17, 2014 at 04:23:08PM -0800, Juston wrote: > On Tue, 2014-11-18 at 01:46 +0300, Dan Carpenter wrote: > > On Mon, Nov 17, 2014 at 02:23:48PM -0800, Juston Li wrote: > > > FMODE_EXEC is type fmode_t but is used in operations > > > with integers which leads to sparse warnings: > > >

Re: [PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

2014-11-18 Thread Greg KH
On Mon, Nov 17, 2014 at 04:23:08PM -0800, Juston wrote: On Tue, 2014-11-18 at 01:46 +0300, Dan Carpenter wrote: On Mon, Nov 17, 2014 at 02:23:48PM -0800, Juston Li wrote: FMODE_EXEC is type fmode_t but is used in operations with integers which leads to sparse warnings:

Re: [PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

2014-11-17 Thread Dan Carpenter
On Mon, Nov 17, 2014 at 04:23:08PM -0800, Juston wrote: > Seems to be the case. Looked at some old commits (2.6.17) and found > FMODE_EXEC was mainlined to allow lustre to be installed on a vanilla > kernel. We actually only care about the most recent kernel. I think you can remove the ifdefs in

Re: [PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

2014-11-17 Thread Juston
On Tue, 2014-11-18 at 01:46 +0300, Dan Carpenter wrote: > On Mon, Nov 17, 2014 at 02:23:48PM -0800, Juston Li wrote: > > FMODE_EXEC is type fmode_t but is used in operations > > with integers which leads to sparse warnings: > > drivers/staging/lustre/lustre/mdc/mdc_lib.c:198:21: warning:

Re: [PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

2014-11-17 Thread Dan Carpenter
On Mon, Nov 17, 2014 at 02:23:48PM -0800, Juston Li wrote: > FMODE_EXEC is type fmode_t but is used in operations > with integers which leads to sparse warnings: > drivers/staging/lustre/lustre/mdc/mdc_lib.c:198:21: warning: restricted > fmode_t degrades to integer >

[PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

2014-11-17 Thread Juston Li
FMODE_EXEC is type fmode_t but is used in operations with integers which leads to sparse warnings: drivers/staging/lustre/lustre/mdc/mdc_lib.c:198:21: warning: restricted fmode_t degrades to integer drivers/staging/lustre/lustre/mdc/mdc_locks.c:300:49: warning: restricted fmode_t degrades to

[PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

2014-11-17 Thread Juston Li
FMODE_EXEC is type fmode_t but is used in operations with integers which leads to sparse warnings: drivers/staging/lustre/lustre/mdc/mdc_lib.c:198:21: warning: restricted fmode_t degrades to integer drivers/staging/lustre/lustre/mdc/mdc_locks.c:300:49: warning: restricted fmode_t degrades to

Re: [PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

2014-11-17 Thread Dan Carpenter
On Mon, Nov 17, 2014 at 02:23:48PM -0800, Juston Li wrote: FMODE_EXEC is type fmode_t but is used in operations with integers which leads to sparse warnings: drivers/staging/lustre/lustre/mdc/mdc_lib.c:198:21: warning: restricted fmode_t degrades to integer

Re: [PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

2014-11-17 Thread Juston
On Tue, 2014-11-18 at 01:46 +0300, Dan Carpenter wrote: On Mon, Nov 17, 2014 at 02:23:48PM -0800, Juston Li wrote: FMODE_EXEC is type fmode_t but is used in operations with integers which leads to sparse warnings: drivers/staging/lustre/lustre/mdc/mdc_lib.c:198:21: warning: restricted

Re: [PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

2014-11-17 Thread Dan Carpenter
On Mon, Nov 17, 2014 at 04:23:08PM -0800, Juston wrote: Seems to be the case. Looked at some old commits (2.6.17) and found FMODE_EXEC was mainlined to allow lustre to be installed on a vanilla kernel. We actually only care about the most recent kernel. I think you can remove the ifdefs in