Re: [PATCH] staging: nvec: fixed few coding style warnings

2015-10-15 Thread Marc Dietrich
Am Donnerstag, 15. Oktober 2015, 11:48:12 schrieb Dan Carpenter: > On Thu, Oct 15, 2015 at 10:39:02AM +0200, Marc Dietrich wrote: > > > > - if (unlikely(nvec->rx == NULL)) { > > > > + if (!unlikely(nvec->rx)) { > > > > > > This isn't right. You

Re: [PATCH] staging: nvec: fixed few coding style warnings

2015-10-15 Thread Dan Carpenter
On Thu, Oct 15, 2015 at 10:39:02AM +0200, Marc Dietrich wrote: > > > - if (unlikely(nvec->rx == NULL)) { > > > + if (!unlikely(nvec->rx)) { > > > > This isn't right. You intented to say: > > > > if (unlikely(!nvec->rx)) { > > > > But even better to just

Re: [PATCH] staging: nvec: fixed few coding style warnings

2015-10-15 Thread Marc Dietrich
Am Mittwoch, 14. Oktober 2015, 21:12:36 schrieb Dan Carpenter: > On Wed, Oct 14, 2015 at 07:38:22PM +0530, Sakshi Bansal wrote: > > Fixed allignmnet issues and block comments usage > > Split it apart by type of fix. > > > @@ -617,7 +618,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)

Re: [PATCH] staging: nvec: fixed few coding style warnings

2015-10-15 Thread Marc Dietrich
Am Mittwoch, 14. Oktober 2015, 21:12:36 schrieb Dan Carpenter: > On Wed, Oct 14, 2015 at 07:38:22PM +0530, Sakshi Bansal wrote: > > Fixed allignmnet issues and block comments usage > > Split it apart by type of fix. > > > @@ -617,7 +618,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)

Re: [PATCH] staging: nvec: fixed few coding style warnings

2015-10-15 Thread Marc Dietrich
Am Donnerstag, 15. Oktober 2015, 11:48:12 schrieb Dan Carpenter: > On Thu, Oct 15, 2015 at 10:39:02AM +0200, Marc Dietrich wrote: > > > > - if (unlikely(nvec->rx == NULL)) { > > > > + if (!unlikely(nvec->rx)) { > > > > > > This isn't right. You

Re: [PATCH] staging: nvec: fixed few coding style warnings

2015-10-15 Thread Dan Carpenter
On Thu, Oct 15, 2015 at 10:39:02AM +0200, Marc Dietrich wrote: > > > - if (unlikely(nvec->rx == NULL)) { > > > + if (!unlikely(nvec->rx)) { > > > > This isn't right. You intented to say: > > > > if (unlikely(!nvec->rx)) { > > > > But even better to just

Re: [PATCH] staging: nvec: fixed few coding style warnings

2015-10-14 Thread Dan Carpenter
On Wed, Oct 14, 2015 at 07:38:22PM +0530, Sakshi Bansal wrote: > Fixed allignmnet issues and block comments usage > Split it apart by type of fix. > @@ -617,7 +618,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) > } else { > nvec->rx =

[PATCH] staging: nvec: fixed few coding style warnings

2015-10-14 Thread Sakshi Bansal
Fixed allignmnet issues and block comments usage Signed-off-by: Sakshi Bansal --- drivers/staging/nvec/README | 2 +- drivers/staging/nvec/nvec.c | 41 --- drivers/staging/nvec/nvec_paz00.c | 1 - drivers/staging/nvec/nvec_power.c | 6 -- 4

Re: [PATCH] staging: nvec: fixed few coding style warnings

2015-10-14 Thread Dan Carpenter
On Wed, Oct 14, 2015 at 07:38:22PM +0530, Sakshi Bansal wrote: > Fixed allignmnet issues and block comments usage > Split it apart by type of fix. > @@ -617,7 +618,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) > } else { > nvec->rx =

[PATCH] staging: nvec: fixed few coding style warnings

2015-10-14 Thread Sakshi Bansal
Fixed allignmnet issues and block comments usage Signed-off-by: Sakshi Bansal --- drivers/staging/nvec/README | 2 +- drivers/staging/nvec/nvec.c | 41 --- drivers/staging/nvec/nvec_paz00.c | 1 -