Re: [PATCH] staging: panel: Fix single-open policy race condition

2014-11-10 Thread Willy Tarreau
On Wed, Nov 05, 2014 at 12:51:22PM +0100, Mariusz Gorski wrote: > On Wed, Nov 05, 2014 at 01:19:10PM +0300, Dan Carpenter wrote: > > On Tue, Nov 04, 2014 at 10:47:19PM +0100, Mariusz Gorski wrote: > > > Fix the implementation of a single-open policy for both > > > devices (lcd and keypad) by using

Re: [PATCH] staging: panel: Fix single-open policy race condition

2014-11-10 Thread Willy Tarreau
On Wed, Nov 05, 2014 at 12:51:22PM +0100, Mariusz Gorski wrote: On Wed, Nov 05, 2014 at 01:19:10PM +0300, Dan Carpenter wrote: On Tue, Nov 04, 2014 at 10:47:19PM +0100, Mariusz Gorski wrote: Fix the implementation of a single-open policy for both devices (lcd and keypad) by using atomic_t

Re: [PATCH] staging: panel: Fix single-open policy race condition

2014-11-05 Thread Mariusz Gorski
On Wed, Nov 05, 2014 at 01:19:10PM +0300, Dan Carpenter wrote: > On Tue, Nov 04, 2014 at 10:47:19PM +0100, Mariusz Gorski wrote: > > Fix the implementation of a single-open policy for both > > devices (lcd and keypad) by using atomic_t instead of plain ints. > > > > This seems like it might be a

Re: [PATCH] staging: panel: Fix single-open policy race condition

2014-11-05 Thread Dan Carpenter
On Tue, Nov 04, 2014 at 10:47:19PM +0100, Mariusz Gorski wrote: > Fix the implementation of a single-open policy for both > devices (lcd and keypad) by using atomic_t instead of plain ints. > This seems like it might be a real life bug that you have experienced? The changelog should tell the

Re: [PATCH] staging: panel: Fix single-open policy race condition

2014-11-05 Thread Dan Carpenter
On Tue, Nov 04, 2014 at 10:47:19PM +0100, Mariusz Gorski wrote: Fix the implementation of a single-open policy for both devices (lcd and keypad) by using atomic_t instead of plain ints. This seems like it might be a real life bug that you have experienced? The changelog should tell the user

Re: [PATCH] staging: panel: Fix single-open policy race condition

2014-11-05 Thread Mariusz Gorski
On Wed, Nov 05, 2014 at 01:19:10PM +0300, Dan Carpenter wrote: On Tue, Nov 04, 2014 at 10:47:19PM +0100, Mariusz Gorski wrote: Fix the implementation of a single-open policy for both devices (lcd and keypad) by using atomic_t instead of plain ints. This seems like it might be a real

[PATCH] staging: panel: Fix single-open policy race condition

2014-11-04 Thread Mariusz Gorski
Fix the implementation of a single-open policy for both devices (lcd and keypad) by using atomic_t instead of plain ints. Signed-off-by: Mariusz Gorski --- drivers/staging/panel/panel.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git

[PATCH] staging: panel: Fix single-open policy race condition

2014-11-04 Thread Mariusz Gorski
Fix the implementation of a single-open policy for both devices (lcd and keypad) by using atomic_t instead of plain ints. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com --- drivers/staging/panel/panel.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git