Re: [PATCH] staging: r8188eu: default to "y" in Kconfig

2014-02-13 Thread Paul Bolle
On Tue, 2014-02-11 at 16:17 +0300, Dan Carpenter wrote: > On Tue, Feb 11, 2014 at 02:01:08PM +0100, Paul Bolle wrote: > > I would have done, if I hadn't bothered to check > > Documentation/SubmittingPatches first. It contains: > >Please note that this tag should not be added without the

Re: [PATCH] staging: r8188eu: default to y in Kconfig

2014-02-13 Thread Paul Bolle
On Tue, 2014-02-11 at 16:17 +0300, Dan Carpenter wrote: On Tue, Feb 11, 2014 at 02:01:08PM +0100, Paul Bolle wrote: I would have done, if I hadn't bothered to check Documentation/SubmittingPatches first. It contains: Please note that this tag should not be added without the reporter's

Re: [PATCH] staging: r8188eu: default to "y" in Kconfig

2014-02-11 Thread Paul Bolle
On Wed, 2014-02-12 at 01:25 +0100, Paul Bolle wrote: > (Greg, is it too late to add this tag in your queue?) Greg already did! It was "USB: ELAN: Remove useless "default M" lines" that lacks a Reported-by: tag. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] staging: r8188eu: default to "y" in Kconfig

2014-02-11 Thread Paul Bolle
On Wed, 2014-02-12 at 01:09 +0100, Martin Walch wrote: > On Tuesday 11 February 2014 13:31:32 Paul Bolle wrote: > > This patch also deserves a > > Reported-by: Martin Walch > > > > line, but that apparently requires Martin's permission. > > I would be happy. It seems I interpreted the

Re: [PATCH] staging: r8188eu: default to "y" in Kconfig

2014-02-11 Thread Martin Walch
On Tuesday 11 February 2014 13:31:32 Paul Bolle wrote: > This patch also deserves a > Reported-by: Martin Walch > > line, but that apparently requires Martin's permission. I would be happy. And I am sorry for not sending patches myself. As I expect to find some more issues in Kconfig files

Re: [PATCH] staging: r8188eu: default to "y" in Kconfig

2014-02-11 Thread Dan Carpenter
On Tue, Feb 11, 2014 at 02:01:08PM +0100, Paul Bolle wrote: > On Tue, 2014-02-11 at 15:53 +0300, Dan Carpenter wrote: > > You've pretty much given Martin's secret assistance away already on a > > public mailing list. Next time just add the Reported-by. :P > > I would have done, if I hadn't

Re: [PATCH] staging: r8188eu: default to "y" in Kconfig

2014-02-11 Thread Paul Bolle
On Tue, 2014-02-11 at 15:53 +0300, Dan Carpenter wrote: > You've pretty much given Martin's secret assistance away already on a > public mailing list. Next time just add the Reported-by. :P I would have done, if I hadn't bothered to check Documentation/SubmittingPatches first. It contains:

Re: [PATCH] staging: r8188eu: default to "y" in Kconfig

2014-02-11 Thread Dan Carpenter
On Tue, Feb 11, 2014 at 01:31:32PM +0100, Paul Bolle wrote: > Two Kconfig entries for this driver default to (uppercase) "Y". But in > Kconfig (lowercase) "y" is a magic symbol. "Y" is an ordinary symbol. > As "Y" is never set these Kconfig symbols will also not be set by > default. > > So use

[PATCH] staging: r8188eu: default to "y" in Kconfig

2014-02-11 Thread Paul Bolle
Two Kconfig entries for this driver default to (uppercase) "Y". But in Kconfig (lowercase) "y" is a magic symbol. "Y" is an ordinary symbol. As "Y" is never set these Kconfig symbols will also not be set by default. So use "default y" here, as was clearly intended. Signed-off-by: Paul Bolle ---

[PATCH] staging: r8188eu: default to y in Kconfig

2014-02-11 Thread Paul Bolle
Two Kconfig entries for this driver default to (uppercase) Y. But in Kconfig (lowercase) y is a magic symbol. Y is an ordinary symbol. As Y is never set these Kconfig symbols will also not be set by default. So use default y here, as was clearly intended. Signed-off-by: Paul Bolle

Re: [PATCH] staging: r8188eu: default to y in Kconfig

2014-02-11 Thread Dan Carpenter
On Tue, Feb 11, 2014 at 01:31:32PM +0100, Paul Bolle wrote: Two Kconfig entries for this driver default to (uppercase) Y. But in Kconfig (lowercase) y is a magic symbol. Y is an ordinary symbol. As Y is never set these Kconfig symbols will also not be set by default. So use default y here,

Re: [PATCH] staging: r8188eu: default to y in Kconfig

2014-02-11 Thread Paul Bolle
On Tue, 2014-02-11 at 15:53 +0300, Dan Carpenter wrote: You've pretty much given Martin's secret assistance away already on a public mailing list. Next time just add the Reported-by. :P I would have done, if I hadn't bothered to check Documentation/SubmittingPatches first. It contains:

Re: [PATCH] staging: r8188eu: default to y in Kconfig

2014-02-11 Thread Dan Carpenter
On Tue, Feb 11, 2014 at 02:01:08PM +0100, Paul Bolle wrote: On Tue, 2014-02-11 at 15:53 +0300, Dan Carpenter wrote: You've pretty much given Martin's secret assistance away already on a public mailing list. Next time just add the Reported-by. :P I would have done, if I hadn't bothered to

Re: [PATCH] staging: r8188eu: default to y in Kconfig

2014-02-11 Thread Martin Walch
On Tuesday 11 February 2014 13:31:32 Paul Bolle wrote: This patch also deserves a Reported-by: Martin Walch walch.mar...@web.de line, but that apparently requires Martin's permission. I would be happy. And I am sorry for not sending patches myself. As I expect to find some more issues in

Re: [PATCH] staging: r8188eu: default to y in Kconfig

2014-02-11 Thread Paul Bolle
On Wed, 2014-02-12 at 01:09 +0100, Martin Walch wrote: On Tuesday 11 February 2014 13:31:32 Paul Bolle wrote: This patch also deserves a Reported-by: Martin Walch walch.mar...@web.de line, but that apparently requires Martin's permission. I would be happy. It seems I interpreted

Re: [PATCH] staging: r8188eu: default to y in Kconfig

2014-02-11 Thread Paul Bolle
On Wed, 2014-02-12 at 01:25 +0100, Paul Bolle wrote: (Greg, is it too late to add this tag in your queue?) Greg already did! It was USB: ELAN: Remove useless default M lines that lacks a Reported-by: tag. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in