Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Greg Kroah-Hartman
On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Greg Kroah-Hartman
On Sat, Jan 31, 2015 at 11:41:04AM -0600, Larry Finger wrote: > On 01/31/2015 10:19 AM, Dan Carpenter wrote: > >On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: > >>while (phead != plist) { > >>- psta = container_of(plist, struct sta_info , list); > >>+

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Larry Finger
On 01/31/2015 10:19 AM, Dan Carpenter wrote: On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: while (phead != plist) { - psta = container_of(plist, struct sta_info , list); + container_of(plist, struct sta_info, list); Argh!!! No. For

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Dan Carpenter
On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: > while (phead != plist) { > - psta = container_of(plist, struct sta_info , list); > + container_of(plist, struct sta_info, list); Argh!!! No. For this one, I didn't need an context to see that

[PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Rickard Strandqvist
Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |3 +-- 1 file

[PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Rickard Strandqvist
Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se ---

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Dan Carpenter
On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: while (phead != plist) { - psta = container_of(plist, struct sta_info , list); + container_of(plist, struct sta_info, list); Argh!!! No. For this one, I didn't need an context to see that it

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Larry Finger
On 01/31/2015 10:19 AM, Dan Carpenter wrote: On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: while (phead != plist) { - psta = container_of(plist, struct sta_info , list); + container_of(plist, struct sta_info, list); Argh!!! No. For

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Greg Kroah-Hartman
On Sat, Jan 31, 2015 at 11:41:04AM -0600, Larry Finger wrote: On 01/31/2015 10:19 AM, Dan Carpenter wrote: On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: while (phead != plist) { - psta = container_of(plist, struct sta_info , list); +

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Greg Kroah-Hartman
On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist