Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-05-06 Thread Gaston Gonzalez
On 27/04/15 07:12, Dan Carpenter wrote: > Can't we just export the tkip.c function? > > regards, > dan carpenter > Hi Dan, (sorry for the delayed response) The inputs of the two implementations of tkip_mixing_phase2() differ in one parameter: - ieee80211_crypt_tkip.c expects 'const u16 *TTAK'

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-05-06 Thread Gaston Gonzalez
On 27/04/15 07:12, Dan Carpenter wrote: Can't we just export the tkip.c function? regards, dan carpenter Hi Dan, (sorry for the delayed response) The inputs of the two implementations of tkip_mixing_phase2() differ in one parameter: - ieee80211_crypt_tkip.c expects 'const u16 *TTAK' -

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-27 Thread Dan Carpenter
Can't we just export the tkip.c function? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-27 Thread Dan Carpenter
Can't we just export the tkip.c function? regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-25 Thread Gaston Gonzalez
On 20/04/15 05:24, Dan Carpenter wrote: > Mk16_le() is a bad function name and as we can see from tkip.c it just > duplicates get_unaligned_le16(). Better to make TK void pointer instead > of a u8 pointer (because it doesn't point to u8s so we have to cast it > every time we use it). This is

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-25 Thread Gaston Gonzalez
On 20/04/15 05:24, Dan Carpenter wrote: Mk16_le() is a bad function name and as we can see from tkip.c it just duplicates get_unaligned_le16(). Better to make TK void pointer instead of a u8 pointer (because it doesn't point to u8s so we have to cast it every time we use it). This is another

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-20 Thread Dan Carpenter
On Sun, Apr 19, 2015 at 05:43:51PM -0300, Gaston Gonzalez wrote: > Silence the following sparse warning: > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:184:16: warning: > cast to restricted __le16 > We have a tkip_mixing_phase2() function in net/mac80211/tkip.c. That's probably

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-20 Thread Dan Carpenter
On Sun, Apr 19, 2015 at 05:43:51PM -0300, Gaston Gonzalez wrote: Silence the following sparse warning: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:184:16: warning: cast to restricted __le16 We have a tkip_mixing_phase2() function in net/mac80211/tkip.c. That's probably the

[PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-19 Thread Gaston Gonzalez
Silence the following sparse warning: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:184:16: warning: cast to restricted __le16 Signed-off-by: Gaston Gonzalez --- .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 22 +++--- 1 file changed, 11 insertions(+), 11

[PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-19 Thread Gaston Gonzalez
Silence the following sparse warning: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:184:16: warning: cast to restricted __le16 Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 22 +++--- 1 file changed, 11