Re: [PATCH] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

2014-05-01 Thread Jes Sorensen
Christian Engelmayer writes: > On Thu, 1 May 2014 14:22:17 +0200, Mateusz Guzik wrote: >> On Thu, May 01, 2014 at 01:57:27PM +0200, Christian Engelmayer wrote: >> > Fix a potential leak in the error path of function update_bcn_wps_ie(). >> > Make sure that allocated memory for

Re: [PATCH] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

2014-05-01 Thread Christian Engelmayer
On Thu, 1 May 2014 14:22:17 +0200, Mateusz Guzik wrote: > On Thu, May 01, 2014 at 01:57:27PM +0200, Christian Engelmayer wrote: > > Fix a potential leak in the error path of function update_bcn_wps_ie(). > > Make sure that allocated memory for 'pbackup_remainder_ie' is freed > > upon return.

Re: [PATCH] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

2014-05-01 Thread Mateusz Guzik
On Thu, May 01, 2014 at 01:57:27PM +0200, Christian Engelmayer wrote: > Fix a potential leak in the error path of function update_bcn_wps_ie(). > Make sure that allocated memory for 'pbackup_remainder_ie' is freed > upon return. Detected by Coverity - CID 1077718. > if (remainder_ielen >

[PATCH] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

2014-05-01 Thread Christian Engelmayer
Fix a potential leak in the error path of function update_bcn_wps_ie(). Make sure that allocated memory for 'pbackup_remainder_ie' is freed upon return. Detected by Coverity - CID 1077718. Signed-off-by: Christian Engelmayer --- Compile tested and applies against branch staging-next of tree

[PATCH] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

2014-05-01 Thread Christian Engelmayer
Fix a potential leak in the error path of function update_bcn_wps_ie(). Make sure that allocated memory for 'pbackup_remainder_ie' is freed upon return. Detected by Coverity - CID 1077718. Signed-off-by: Christian Engelmayer cenge...@gmx.at --- Compile tested and applies against branch

Re: [PATCH] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

2014-05-01 Thread Mateusz Guzik
On Thu, May 01, 2014 at 01:57:27PM +0200, Christian Engelmayer wrote: Fix a potential leak in the error path of function update_bcn_wps_ie(). Make sure that allocated memory for 'pbackup_remainder_ie' is freed upon return. Detected by Coverity - CID 1077718. if (remainder_ielen 0) {

Re: [PATCH] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

2014-05-01 Thread Christian Engelmayer
On Thu, 1 May 2014 14:22:17 +0200, Mateusz Guzik mgu...@redhat.com wrote: On Thu, May 01, 2014 at 01:57:27PM +0200, Christian Engelmayer wrote: Fix a potential leak in the error path of function update_bcn_wps_ie(). Make sure that allocated memory for 'pbackup_remainder_ie' is freed upon

Re: [PATCH] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

2014-05-01 Thread Jes Sorensen
Christian Engelmayer cenge...@gmx.at writes: On Thu, 1 May 2014 14:22:17 +0200, Mateusz Guzik mgu...@redhat.com wrote: On Thu, May 01, 2014 at 01:57:27PM +0200, Christian Engelmayer wrote: Fix a potential leak in the error path of function update_bcn_wps_ie(). Make sure that allocated memory