Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Joe Perches
On Fri, 2013-12-06 at 10:11 +0300, Dan Carpenter wrote: > On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote: > > On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote: > > > On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: > > > > On Fri, 2013-12-06 at 01:50 +0300, Dan

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Dan Carpenter
On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote: > On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote: > > On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: > > > On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: > > > > On Thu, Dec 05, 2013 at 10:23:53PM +0100,

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Joe Perches
On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote: > On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: > > On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: > > > On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote: > > > > Fixes warnings regarding redundant

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Dan Carpenter
On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: > On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: > > On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote: > > > Fixes warnings regarding redundant parantheses thrown by the checkpatch > > > tool in bpctl_mod.c > [] > >

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Joe Perches
On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: > On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote: > > Fixes warnings regarding redundant parantheses thrown by the checkpatch > > tool in bpctl_mod.c [] > if (ret < 0) > return BP_NOT_CAP; > if (ret ==

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Dan Carpenter
On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote: > Fixes warnings regarding redundant parantheses thrown by the checkpatch tool > in bpctl_mod.c > Fair enough, but if you wanted to go clean the returns up further then you could. Remove all the "!= 0" bits. > @@ -3125,11 +3125,11 @@

[PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Will Tange
Fixes warnings regarding redundant parantheses thrown by the checkpatch tool in bpctl_mod.c Signed-off-by: Will Tange --- drivers/staging/silicom/bpctl_mod.c | 122 ++-- 1 file changed, 61 insertions(+), 61 deletions(-) diff --git

[PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Will Tange
Fixes warnings regarding redundant parantheses thrown by the checkpatch tool in bpctl_mod.c Signed-off-by: Will Tange bh3...@gmail.com --- drivers/staging/silicom/bpctl_mod.c | 122 ++-- 1 file changed, 61 insertions(+), 61 deletions(-) diff --git

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Dan Carpenter
On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote: Fixes warnings regarding redundant parantheses thrown by the checkpatch tool in bpctl_mod.c Fair enough, but if you wanted to go clean the returns up further then you could. Remove all the != 0 bits. @@ -3125,11 +3125,11 @@

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Joe Perches
On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote: Fixes warnings regarding redundant parantheses thrown by the checkpatch tool in bpctl_mod.c [] if (ret 0) return BP_NOT_CAP; if (ret == 0)

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Dan Carpenter
On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote: Fixes warnings regarding redundant parantheses thrown by the checkpatch tool in bpctl_mod.c [] if (ret

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Joe Perches
On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote: Fixes warnings regarding redundant parantheses thrown

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Dan Carpenter
On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote: On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange

Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c

2013-12-05 Thread Joe Perches
On Fri, 2013-12-06 at 10:11 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote: On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote: On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter