Re: [PATCH] staging: unisys: use schedule_timeout_interruptible()

2015-06-01 Thread Ben Romer
As the actually intended timeout is not documented and msecs_to_jiffies timeouts can be a factor 10 different from the current effective timeout this needs to be checked by someone who knows the details of this driver in any case it should be passed in a HZ independent manner. I need an ack

Re: [PATCH] staging: unisys: use schedule_timeout_interruptible()

2015-06-01 Thread Ben Romer
As the actually intended timeout is not documented and msecs_to_jiffies timeouts can be a factor 10 different from the current effective timeout this needs to be checked by someone who knows the details of this driver in any case it should be passed in a HZ independent manner. I need an ack

Re: [PATCH] staging: unisys: use schedule_timeout_interruptible()

2015-05-30 Thread Greg Kroah-Hartman
On Fri, May 29, 2015 at 05:31:16PM +0200, Nicholas Mc Guire wrote: > API consolidation with coccinelle found: > ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19: > consolidation with schedule_timeout_*() recommended > > This is a 1:1 conversion with respect to schedule_timeout()

Re: [PATCH] staging: unisys: use schedule_timeout_interruptible()

2015-05-30 Thread Greg Kroah-Hartman
On Fri, May 29, 2015 at 05:31:16PM +0200, Nicholas Mc Guire wrote: API consolidation with coccinelle found: ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion with respect to schedule_timeout() to

[PATCH] staging: unisys: use schedule_timeout_interruptible()

2015-05-29 Thread Nicholas Mc Guire
API consolidation with coccinelle found: ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion with respect to schedule_timeout() to the schedule_timeout_interruptible() helper only - so only an API

[PATCH] staging: unisys: use schedule_timeout_interruptible()

2015-05-29 Thread Nicholas Mc Guire
API consolidation with coccinelle found: ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion with respect to schedule_timeout() to the schedule_timeout_interruptible() helper only - so only an API