Re: [PATCH] sunrpc: fix crash when cache_head become valid before update

2019-10-11 Thread J . Bruce Fields
On Wed, Oct 09, 2019 at 09:51:23AM +1100, NeilBrown wrote: > On Tue, Oct 08 2019, J . Bruce Fields wrote: > > > On Tue, Oct 08, 2019 at 10:02:53AM +, Pavel Tikhomirov wrote: > >> Add Neil to CC, sorry, had lost it somehow... > > > > Always happy when we can fix a bug by deleting code, and yo

Re: [PATCH] sunrpc: fix crash when cache_head become valid before update

2019-10-08 Thread NeilBrown
On Tue, Oct 08 2019, J . Bruce Fields wrote: > On Tue, Oct 08, 2019 at 10:02:53AM +, Pavel Tikhomirov wrote: >> Add Neil to CC, sorry, had lost it somehow... > > Always happy when we can fix a bug by deleting code, and your > explanation makes sense to me, but I'll give Neil a chance to look

Re: [PATCH] sunrpc: fix crash when cache_head become valid before update

2019-10-08 Thread J . Bruce Fields
On Tue, Oct 08, 2019 at 10:02:53AM +, Pavel Tikhomirov wrote: > Add Neil to CC, sorry, had lost it somehow... Always happy when we can fix a bug by deleting code, and your explanation makes sense to me, but I'll give Neil a chance to look it over if he wants. --b. > > On 10/1/19 11:03 AM, P

Re: [PATCH] sunrpc: fix crash when cache_head become valid before update

2019-10-08 Thread Pavel Tikhomirov
Add Neil to CC, sorry, had lost it somehow... On 10/1/19 11:03 AM, Pavel Tikhomirov wrote: > I was investigating a crash in our Virtuozzo7 kernel which happened in > in svcauth_unix_set_client. I found out that we access m_client field > in ip_map structure, which was received from sunrpc_cache_lo

[PATCH] sunrpc: fix crash when cache_head become valid before update

2019-10-01 Thread Pavel Tikhomirov
I was investigating a crash in our Virtuozzo7 kernel which happened in in svcauth_unix_set_client. I found out that we access m_client field in ip_map structure, which was received from sunrpc_cache_lookup (we have a bit older kernel, now the code is in sunrpc_cache_add_entry), and these field look