Re: [PATCH] sysfs: add sysfs_create/remove_groups()

2013-08-22 Thread Greg Kroah-Hartman
On Wed, Aug 21, 2013 at 10:55:19PM -0600, Anthony Foiani wrote: > Greg Kroah-Hartman writes: > > > + * sysfs_create_groups - given a directory kobject, create a bunch of > > attribute groups > > + * @kobj: The kobject to create the group on > > + * @groups:The attribute groups to

Re: [PATCH] sysfs: add sysfs_create/remove_groups()

2013-08-22 Thread Greg Kroah-Hartman
On Wed, Aug 21, 2013 at 10:55:19PM -0600, Anthony Foiani wrote: Greg Kroah-Hartman gre...@linuxfoundation.org writes: + * sysfs_create_groups - given a directory kobject, create a bunch of attribute groups + * @kobj: The kobject to create the group on + * @groups:The attribute

Re: [PATCH] sysfs: add sysfs_create/remove_groups()

2013-08-21 Thread Anthony Foiani
Greg Kroah-Hartman writes: > + * sysfs_create_groups - given a directory kobject, create a bunch of > attribute groups > + * @kobj:The kobject to create the group on > + * @groups: The attribute groups to create, NULL terminated > + * > + * This function creates a bunch of attribute

[PATCH] sysfs: add sysfs_create/remove_groups()

2013-08-21 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman These functions are being open-coded in 3 different places in the driver core, and other driver subsystems will want to start doing this as well, so move it to the sysfs core to keep it all in one place, where we know it is written properly. Signed-off-by: Greg

Re: [PATCH] sysfs: add sysfs_create/remove_groups()

2013-08-21 Thread Greg Kroah-Hartman
On Wed, Aug 21, 2013 at 01:38:35PM -0700, Randy Dunlap wrote: > On 08/21/13 13:35, Greg Kroah-Hartman wrote: > > > > --- a/fs/sysfs/group.c > > +++ b/fs/sysfs/group.c > > @@ -131,6 +131,39 @@ int sysfs_create_group(struct kobject *k > > } > > > > /** > > + * sysfs_create_groups - given a

Re: [PATCH] sysfs: add sysfs_create/remove_groups()

2013-08-21 Thread Randy Dunlap
On 08/21/13 13:35, Greg Kroah-Hartman wrote: > > --- a/fs/sysfs/group.c > +++ b/fs/sysfs/group.c > @@ -131,6 +131,39 @@ int sysfs_create_group(struct kobject *k > } > > /** > + * sysfs_create_groups - given a directory kobject, create a bunch of > attribute groups > + * @kobj:The kobject

[PATCH] sysfs: add sysfs_create/remove_groups()

2013-08-21 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman These functions are being open-coded in 3 different places in the driver core, and other driver subsystems will want to start doing this as well, so move it to the sysfs core to keep it all in one place, where we know it is written properly. Signed-off-by: Greg

[PATCH] sysfs: add sysfs_create/remove_groups()

2013-08-21 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org These functions are being open-coded in 3 different places in the driver core, and other driver subsystems will want to start doing this as well, so move it to the sysfs core to keep it all in one place, where we know it is written properly.

Re: [PATCH] sysfs: add sysfs_create/remove_groups()

2013-08-21 Thread Randy Dunlap
On 08/21/13 13:35, Greg Kroah-Hartman wrote: --- a/fs/sysfs/group.c +++ b/fs/sysfs/group.c @@ -131,6 +131,39 @@ int sysfs_create_group(struct kobject *k } /** + * sysfs_create_groups - given a directory kobject, create a bunch of attribute groups + * @kobj:The kobject to create

Re: [PATCH] sysfs: add sysfs_create/remove_groups()

2013-08-21 Thread Greg Kroah-Hartman
On Wed, Aug 21, 2013 at 01:38:35PM -0700, Randy Dunlap wrote: On 08/21/13 13:35, Greg Kroah-Hartman wrote: --- a/fs/sysfs/group.c +++ b/fs/sysfs/group.c @@ -131,6 +131,39 @@ int sysfs_create_group(struct kobject *k } /** + * sysfs_create_groups - given a directory kobject,

[PATCH] sysfs: add sysfs_create/remove_groups()

2013-08-21 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org These functions are being open-coded in 3 different places in the driver core, and other driver subsystems will want to start doing this as well, so move it to the sysfs core to keep it all in one place, where we know it is written properly.

Re: [PATCH] sysfs: add sysfs_create/remove_groups()

2013-08-21 Thread Anthony Foiani
Greg Kroah-Hartman gre...@linuxfoundation.org writes: + * sysfs_create_groups - given a directory kobject, create a bunch of attribute groups + * @kobj:The kobject to create the group on + * @groups: The attribute groups to create, NULL terminated + * + * This function creates a bunch