Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-04 Thread Jason Xing
On Wed, Jun 3, 2020 at 10:08 PM Neal Cardwell wrote: > > On Wed, Jun 3, 2020 at 9:55 AM Eric Dumazet wrote: > > > > On Wed, Jun 3, 2020 at 5:02 AM Neal Cardwell wrote: > > > > > > On Wed, Jun 3, 2020 at 1:44 AM Eric Dumazet wrote: > > > > > > > > On Tue, Jun 2, 2020 at 10:05 PM Jason Xing >

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-03 Thread Neal Cardwell
On Wed, Jun 3, 2020 at 9:55 AM Eric Dumazet wrote: > > On Wed, Jun 3, 2020 at 5:02 AM Neal Cardwell wrote: > > > > On Wed, Jun 3, 2020 at 1:44 AM Eric Dumazet wrote: > > > > > > On Tue, Jun 2, 2020 at 10:05 PM Jason Xing > > > wrote: > > > > > > > > Hi Eric, > > > > > > > > I'm still trying

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-03 Thread Eric Dumazet
On Wed, Jun 3, 2020 at 5:02 AM Neal Cardwell wrote: > > On Wed, Jun 3, 2020 at 1:44 AM Eric Dumazet wrote: > > > > On Tue, Jun 2, 2020 at 10:05 PM Jason Xing > > wrote: > > > > > > Hi Eric, > > > > > > I'm still trying to understand what you're saying before. Would this > > > be better as

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-03 Thread Jason Xing
On Wed, Jun 3, 2020 at 8:02 PM Neal Cardwell wrote: > > On Wed, Jun 3, 2020 at 1:44 AM Eric Dumazet wrote: > > > > On Tue, Jun 2, 2020 at 10:05 PM Jason Xing > > wrote: > > > > > > Hi Eric, > > > > > > I'm still trying to understand what you're saying before. Would this > > > be better as

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-03 Thread Neal Cardwell
On Wed, Jun 3, 2020 at 1:44 AM Eric Dumazet wrote: > > On Tue, Jun 2, 2020 at 10:05 PM Jason Xing wrote: > > > > Hi Eric, > > > > I'm still trying to understand what you're saying before. Would this > > be better as following: > > 1) discard the tcp_internal_pacing() function. > > 2) remove

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-03 Thread Jason Xing
On Wed, Jun 3, 2020 at 1:44 PM Eric Dumazet wrote: > > On Tue, Jun 2, 2020 at 10:05 PM Jason Xing wrote: > > > > Hi Eric, > > > > I'm still trying to understand what you're saying before. Would this > > be better as following: > > 1) discard the tcp_internal_pacing() function. > > 2) remove

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Eric Dumazet
On Tue, Jun 2, 2020 at 10:05 PM Jason Xing wrote: > > Hi Eric, > > I'm still trying to understand what you're saying before. Would this > be better as following: > 1) discard the tcp_internal_pacing() function. > 2) remove where the tcp_internal_pacing() is called in the > __tcp_transmit_skb()

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Jason Xing
Hi Eric, I'm still trying to understand what you're saying before. Would this be better as following: 1) discard the tcp_internal_pacing() function. 2) remove where the tcp_internal_pacing() is called in the __tcp_transmit_skb() function. If we do so, we could avoid 'too late to give up pacing'.

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Jason Xing
Thanks for reminding me. I will test the cases through using sch_fq. Jason On Wed, Jun 3, 2020 at 10:44 AM Eric Dumazet wrote: > > On Tue, Jun 2, 2020 at 7:42 PM Jason Xing wrote: > > > > I agree with you. The upstream has already dropped and optimized this > > part (commit 864e5c090749), so

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Eric Dumazet
On Tue, Jun 2, 2020 at 7:42 PM Jason Xing wrote: > > I agree with you. The upstream has already dropped and optimized this > part (commit 864e5c090749), so it would not happen like that. However > the old kernels like LTS still have the problem which causes > large-scale crashes on our thousands

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Jason Xing
I agree with you. The upstream has already dropped and optimized this part (commit 864e5c090749), so it would not happen like that. However the old kernels like LTS still have the problem which causes large-scale crashes on our thousands of machines after running for a long while. I will send the

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Eric Dumazet
On Tue, Jun 2, 2020 at 6:53 PM Jason Xing wrote: > > Hi Eric, > > I'm sorry that I didn't write enough clearly. We're running the > pristine 4.19.125 linux kernel (the latest LTS version) and have been > haunted by such an issue. This patch is high-important, I think. So > I'm going to resend

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread David Miller
From: Jason Xing Date: Wed, 3 Jun 2020 09:53:10 +0800 > I'm sorry that I didn't write enough clearly. We're running the > pristine 4.19.125 linux kernel (the latest LTS version) and have been > haunted by such an issue. This patch is high-important, I think. So > I'm going to resend this email

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Jason Xing
Hi Eric, I'm sorry that I didn't write enough clearly. We're running the pristine 4.19.125 linux kernel (the latest LTS version) and have been haunted by such an issue. This patch is high-important, I think. So I'm going to resend this email with the [patch 4.19] on the headline and cc Greg.

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Eric Dumazet
On Tue, Jun 2, 2020 at 1:05 AM wrote: > > From: Jason Xing > > TCP socks cannot be released because of the sock_hold() increasing the > sk_refcnt in the manner of tcp_internal_pacing() when RTO happens. > Therefore, this situation could increase the slab memory and then trigger > the OOM if the

[PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread kerneljasonxing
From: Jason Xing TCP socks cannot be released because of the sock_hold() increasing the sk_refcnt in the manner of tcp_internal_pacing() when RTO happens. Therefore, this situation could increase the slab memory and then trigger the OOM if the machine has beening running for a long time. This