Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

From: Shannon Nelson Date: Thu, 12 Jan 2017 13:58:10 -0800 > > > On 1/12/2017 1:47 PM, David Miller wrote: >> From: Eric Dumazet >> Date: Thu, 12 Jan 2017 13:36:30 -0800 >> >>> val should be an union, so that proper alignment is enforced by

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

From: Shannon Nelson Date: Thu, 12 Jan 2017 13:58:10 -0800 > > > On 1/12/2017 1:47 PM, David Miller wrote: >> From: Eric Dumazet >> Date: Thu, 12 Jan 2017 13:36:30 -0800 >> >>> val should be an union, so that proper alignment is enforced by one >>> member. >> >> Sure, annotating the type so

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On 1/12/2017 1:47 PM, David Miller wrote: From: Eric Dumazet Date: Thu, 12 Jan 2017 13:36:30 -0800 val should be an union, so that proper alignment is enforced by one member. Sure, annotating the type so that it is aligned correctly makes sense. ... and we

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On 1/12/2017 1:47 PM, David Miller wrote: From: Eric Dumazet Date: Thu, 12 Jan 2017 13:36:30 -0800 val should be an union, so that proper alignment is enforced by one member. Sure, annotating the type so that it is aligned correctly makes sense. ... and we should change the offending

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

From: Eric Dumazet Date: Thu, 12 Jan 2017 13:36:30 -0800 > val should be an union, so that proper alignment is enforced by one > member. Sure, annotating the type so that it is aligned correctly makes sense.

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

From: Eric Dumazet Date: Thu, 12 Jan 2017 13:36:30 -0800 > val should be an union, so that proper alignment is enforced by one > member. Sure, annotating the type so that it is aligned correctly makes sense.

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On Thu, 2017-01-12 at 16:18 -0500, David Miller wrote: > From: Shannon Nelson > Date: Thu, 12 Jan 2017 12:56:08 -0800 > > > > > > > On 1/12/2017 12:41 PM, David Miller wrote: > >> From: Shannon Nelson > >> Date: Thu, 12 Jan 2017 12:30:38

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On Thu, 2017-01-12 at 16:18 -0500, David Miller wrote: > From: Shannon Nelson > Date: Thu, 12 Jan 2017 12:56:08 -0800 > > > > > > > On 1/12/2017 12:41 PM, David Miller wrote: > >> From: Shannon Nelson > >> Date: Thu, 12 Jan 2017 12:30:38 -0800 > >> > >>> On 1/12/2017 12:25 PM, Eric Dumazet

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

From: Shannon Nelson Date: Thu, 12 Jan 2017 12:56:08 -0800 > > > On 1/12/2017 12:41 PM, David Miller wrote: >> From: Shannon Nelson >> Date: Thu, 12 Jan 2017 12:30:38 -0800 >> >>> On 1/12/2017 12:25 PM, Eric Dumazet wrote: On Thu,

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

From: Shannon Nelson Date: Thu, 12 Jan 2017 12:56:08 -0800 > > > On 1/12/2017 12:41 PM, David Miller wrote: >> From: Shannon Nelson >> Date: Thu, 12 Jan 2017 12:30:38 -0800 >> >>> On 1/12/2017 12:25 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: >

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On 1/12/2017 12:41 PM, David Miller wrote: From: Shannon Nelson Date: Thu, 12 Jan 2017 12:30:38 -0800 On 1/12/2017 12:25 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: I suspect that someplace, somebody is casting val to an int *

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On 1/12/2017 12:41 PM, David Miller wrote: From: Shannon Nelson Date: Thu, 12 Jan 2017 12:30:38 -0800 On 1/12/2017 12:25 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: I suspect that someplace, somebody is casting val to an int * or something like that.

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

From: Shannon Nelson Date: Thu, 12 Jan 2017 12:30:38 -0800 > On 1/12/2017 12:25 PM, Eric Dumazet wrote: >> On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: >> >>> >>> I suspect that someplace, somebody is casting val to an int * or >>> something like that. >> >>

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

From: Shannon Nelson Date: Thu, 12 Jan 2017 12:30:38 -0800 > On 1/12/2017 12:25 PM, Eric Dumazet wrote: >> On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: >> >>> >>> I suspect that someplace, somebody is casting val to an int * or >>> something like that. >> >> Then that would be the bug.

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

From: Eric Dumazet Date: Thu, 12 Jan 2017 12:25:33 -0800 > On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: > >> >> I suspect that someplace, somebody is casting val to an int * or >> something like that. > > Then that would be the bug. Can we root cause this

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

From: Eric Dumazet Date: Thu, 12 Jan 2017 12:25:33 -0800 > On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: > >> >> I suspect that someplace, somebody is casting val to an int * or >> something like that. > > Then that would be the bug. Can we root cause this please ? The three

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On 1/12/2017 12:25 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: I suspect that someplace, somebody is casting val to an int * or something like that. Then that would be the bug. Can we root cause this please ? Look in

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On 1/12/2017 12:25 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: I suspect that someplace, somebody is casting val to an int * or something like that. Then that would be the bug. Can we root cause this please ? Look in

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: > > I suspect that someplace, somebody is casting val to an int * or > something like that. Then that would be the bug. Can we root cause this please ?

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: > > I suspect that someplace, somebody is casting val to an int * or > something like that. Then that would be the bug. Can we root cause this please ?

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On 01/12/2017 01:13 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 11:59 -0800, Shannon Nelson wrote: Fix up a data alignment issue on sparc by swapping the order of the cookie byte array field with the length field in struct tcp_fastopen_cookie This addresses log complaints like these:

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On 01/12/2017 01:13 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 11:59 -0800, Shannon Nelson wrote: Fix up a data alignment issue on sparc by swapping the order of the cookie byte array field with the length field in struct tcp_fastopen_cookie This addresses log complaints like these:

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On Thu, 2017-01-12 at 11:59 -0800, Shannon Nelson wrote: > Fix up a data alignment issue on sparc by swapping the order > of the cookie byte array field with the length field in > struct tcp_fastopen_cookie > > This addresses log complaints like these: > log_unaligned: 113 callbacks

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

On Thu, 2017-01-12 at 11:59 -0800, Shannon Nelson wrote: > Fix up a data alignment issue on sparc by swapping the order > of the cookie byte array field with the length field in > struct tcp_fastopen_cookie > > This addresses log complaints like these: > log_unaligned: 113 callbacks

[PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

Fix up a data alignment issue on sparc by swapping the order of the cookie byte array field with the length field in struct tcp_fastopen_cookie This addresses log complaints like these: log_unaligned: 113 callbacks suppressed Kernel unaligned access at TPC[976490]

[PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

Fix up a data alignment issue on sparc by swapping the order of the cookie byte array field with the length field in struct tcp_fastopen_cookie This addresses log complaints like these: log_unaligned: 113 callbacks suppressed Kernel unaligned access at TPC[976490]