Re: [PATCH] tee/tee_shm.c: Fix error handling path

2020-09-13 Thread Souptick Joarder
On Mon, Sep 14, 2020 at 1:59 AM Jens Wiklander wrote: > > On Sun, Sep 13, 2020 at 10:12:11AM +0530, Souptick Joarder wrote: > > When shm->num_pages <= 0, we should avoid calling > > release_registered_pages() in error handling path. > What are we fixing? Current code is working fine and this

Re: [PATCH] tee/tee_shm.c: Fix error handling path

2020-09-13 Thread Jens Wiklander
On Sun, Sep 13, 2020 at 10:12:11AM +0530, Souptick Joarder wrote: > When shm->num_pages <= 0, we should avoid calling > release_registered_pages() in error handling path. What are we fixing? > > Signed-off-by: Souptick Joarder > Cc: John Hubbard > --- > drivers/tee/tee_shm.c | 7 --- > 1

Re: [PATCH] tee/tee_shm.c: Fix error handling path

2020-09-13 Thread Souptick Joarder
On Sun, Sep 13, 2020 at 2:00 PM Markus Elfring wrote: > > > When shm->num_pages <= 0, we should avoid calling > > release_registered_pages() in error handling path. > > * Would an imperative wording become helpful for the change description? > > * I suggest to add the tag “Fixes” to the commit

[PATCH] tee/tee_shm.c: Fix error handling path

2020-09-12 Thread Souptick Joarder
When shm->num_pages <= 0, we should avoid calling release_registered_pages() in error handling path. Signed-off-by: Souptick Joarder Cc: John Hubbard --- drivers/tee/tee_shm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/tee/tee_shm.c