Re: [PATCH] test-hexdump: test the return value of the hex_dump_to_buffer

2015-02-25 Thread long.wanglong
On 2015/2/16 17:47, Andy Shevchenko wrote: > On Sun, 2015-02-15 at 09:50 +, Wang Long wrote: >> As the function hex_dump_to_buffer returns the amount of bytes placed >> in the buffer without terminating NUL. the test-hexdump should test >> the return value of it. > > I don't think it's

Re: [PATCH] test-hexdump: test the return value of the hex_dump_to_buffer

2015-02-25 Thread long.wanglong
On 2015/2/16 17:47, Andy Shevchenko wrote: On Sun, 2015-02-15 at 09:50 +, Wang Long wrote: As the function hex_dump_to_buffer returns the amount of bytes placed in the buffer without terminating NUL. the test-hexdump should test the return value of it. I don't think it's needed. When

Re: [PATCH] test-hexdump: test the return value of the hex_dump_to_buffer

2015-02-16 Thread Andy Shevchenko
On Sun, 2015-02-15 at 09:50 +, Wang Long wrote: > As the function hex_dump_to_buffer returns the amount of bytes placed > in the buffer without terminating NUL. the test-hexdump should test > the return value of it. I don't think it's needed. When the prototype was changed the new test case

Re: [PATCH] test-hexdump: test the return value of the hex_dump_to_buffer

2015-02-16 Thread Andy Shevchenko
On Sun, 2015-02-15 at 09:50 +, Wang Long wrote: As the function hex_dump_to_buffer returns the amount of bytes placed in the buffer without terminating NUL. the test-hexdump should test the return value of it. I don't think it's needed. When the prototype was changed the new test case had

[PATCH] test-hexdump: test the return value of the hex_dump_to_buffer

2015-02-15 Thread Wang Long
As the function hex_dump_to_buffer returns the amount of bytes placed in the buffer without terminating NUL. the test-hexdump should test the return value of it. Signed-off-by: Wang Long --- lib/test-hexdump.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH] test-hexdump: test the return value of the hex_dump_to_buffer

2015-02-15 Thread Wang Long
As the function hex_dump_to_buffer returns the amount of bytes placed in the buffer without terminating NUL. the test-hexdump should test the return value of it. Signed-off-by: Wang Long long.wangl...@huawei.com --- lib/test-hexdump.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)