Re: [PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable()

2013-02-25 Thread Artem Savkov
On Mon, Feb 25, 2013 at 03:54:45PM -0800, Andrew Morton wrote: > On Sun, 24 Feb 2013 13:22:02 +0400 > Artem Savkov wrote: > > > set_freezable() checks freezing during which no locks should be held. > > hotkey_thread_mutex lock should be moved closer to where it is actually > > needed. > > > >

Re: [PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable()

2013-02-25 Thread Andrew Morton
On Sun, 24 Feb 2013 13:22:02 +0400 Artem Savkov wrote: > set_freezable() checks freezing during which no locks should be held. > hotkey_thread_mutex lock should be moved closer to where it is actually > needed. > Thanks. When fixing a bug, we always like to see a full description of that bug

Re: [PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable()

2013-02-25 Thread Artem Savkov
On Mon, Feb 25, 2013 at 03:54:45PM -0800, Andrew Morton wrote: On Sun, 24 Feb 2013 13:22:02 +0400 Artem Savkov artem.sav...@gmail.com wrote: set_freezable() checks freezing during which no locks should be held. hotkey_thread_mutex lock should be moved closer to where it is actually

Re: [PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable()

2013-02-25 Thread Andrew Morton
On Sun, 24 Feb 2013 13:22:02 +0400 Artem Savkov artem.sav...@gmail.com wrote: set_freezable() checks freezing during which no locks should be held. hotkey_thread_mutex lock should be moved closer to where it is actually needed. Thanks. When fixing a bug, we always like to see a full

[PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable()

2013-02-24 Thread Artem Savkov
set_freezable() checks freezing during which no locks should be held. hotkey_thread_mutex lock should be moved closer to where it is actually needed. Signed-off-by: Artem Savkov --- drivers/platform/x86/thinkpad_acpi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable()

2013-02-24 Thread Artem Savkov
set_freezable() checks freezing during which no locks should be held. hotkey_thread_mutex lock should be moved closer to where it is actually needed. Signed-off-by: Artem Savkov artem.sav...@gmail.com --- drivers/platform/x86/thinkpad_acpi.c | 6 +++--- 1 file changed, 3 insertions(+), 3