Re: [PATCH] thunderbolt: Fix double free of drom buffer

2016-05-02 Thread Andreas Noever
On Mon, May 2, 2016 at 7:30 PM, Bjorn Helgaas wrote: > On Sun, Apr 10, 2016 at 12:48:27PM +0200, Andreas Noever wrote: >> If tb_drom_read fails sw->drom is freed but not set to NULL. sw->drom >> is then freed again in the error path of sw_switch_alloc. > >

Re: [PATCH] thunderbolt: Fix double free of drom buffer

2016-05-02 Thread Andreas Noever
On Mon, May 2, 2016 at 7:30 PM, Bjorn Helgaas wrote: > On Sun, Apr 10, 2016 at 12:48:27PM +0200, Andreas Noever wrote: >> If tb_drom_read fails sw->drom is freed but not set to NULL. sw->drom >> is then freed again in the error path of sw_switch_alloc. > > s/sw_switch_alloc/tb_switch_alloc/ ? >

Re: [PATCH] thunderbolt: Fix double free of drom buffer

2016-05-02 Thread Bjorn Helgaas
On Sun, Apr 10, 2016 at 12:48:27PM +0200, Andreas Noever wrote: > If tb_drom_read fails sw->drom is freed but not set to NULL. sw->drom > is then freed again in the error path of sw_switch_alloc. s/sw_switch_alloc/tb_switch_alloc/ ? > The bug can be triggered by unplugging a thunderbolt device

Re: [PATCH] thunderbolt: Fix double free of drom buffer

2016-05-02 Thread Bjorn Helgaas
On Sun, Apr 10, 2016 at 12:48:27PM +0200, Andreas Noever wrote: > If tb_drom_read fails sw->drom is freed but not set to NULL. sw->drom > is then freed again in the error path of sw_switch_alloc. s/sw_switch_alloc/tb_switch_alloc/ ? > The bug can be triggered by unplugging a thunderbolt device

[PATCH] thunderbolt: Fix double free of drom buffer

2016-04-10 Thread Andreas Noever
If tb_drom_read fails sw->drom is freed but not set to NULL. sw->drom is then freed again in the error path of sw_switch_alloc. The bug can be triggered by unplugging a thunderbolt device shortly after it is detected by the thunderbolt driver. Signed-off-by: Andreas Noever

[PATCH] thunderbolt: Fix double free of drom buffer

2016-04-10 Thread Andreas Noever
If tb_drom_read fails sw->drom is freed but not set to NULL. sw->drom is then freed again in the error path of sw_switch_alloc. The bug can be triggered by unplugging a thunderbolt device shortly after it is detected by the thunderbolt driver. Signed-off-by: Andreas Noever Cc: Lukas Wunner Cc: