Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-21 Thread Eduardo Valentin
On Sun, Jan 18, 2015 at 09:18:21PM +0100, Pavel Machek wrote: > Hi! > > > > Ok, what do you suggest? AFAICT, without MODE_CONFIG, continuous ADC > > > mode is not available, so we have to force it periodically, so this > > > should be correct. > > > > I will have a better look and let you know.

Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-21 Thread Eduardo Valentin
On Sun, Jan 18, 2015 at 09:18:21PM +0100, Pavel Machek wrote: Hi! Ok, what do you suggest? AFAICT, without MODE_CONFIG, continuous ADC mode is not available, so we have to force it periodically, so this should be correct. I will have a better look and let you know. for now, adding

Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-18 Thread Pavel Machek
Hi! > > Ok, what do you suggest? AFAICT, without MODE_CONFIG, continuous ADC > > mode is not available, so we have to force it periodically, so this > > should be correct. > > I will have a better look and let you know. for now, adding a single > read should not hurt ( but I will double check)

Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-18 Thread Pavel Machek
Hi! Ok, what do you suggest? AFAICT, without MODE_CONFIG, continuous ADC mode is not available, so we have to force it periodically, so this should be correct. I will have a better look and let you know. for now, adding a single read should not hurt ( but I will double check) Any news

Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-05 Thread Eduardo Valentin
On Sat, Jan 03, 2015 at 05:22:42PM +0100, Pavel Machek wrote: > Hi! > > > > When periodic mode is not enabled, it is neccessary to force reads. > > > > > > Signed-off-by: Pavel Machek > > > > > > > --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c > > > +++

Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-05 Thread Eduardo Valentin
On Sat, Jan 03, 2015 at 05:22:42PM +0100, Pavel Machek wrote: Hi! When periodic mode is not enabled, it is neccessary to force reads. Signed-off-by: Pavel Machek pa...@ucw.cz --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c +++

Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-03 Thread Pavel Machek
Hi! > > When periodic mode is not enabled, it is neccessary to force reads. > > > > Signed-off-by: Pavel Machek > > > > --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c > > +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c > > @@ -43,6 +43,8 @@ > > > > #include "ti-bandgap.h" > > > >

Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-03 Thread Eduardo Valentin
On Sat, Jan 03, 2015 at 12:46:32PM +0100, Pavel Machek wrote: > For omap3, proper implementation of eocz bit is needed. It was > actually a TODO in the driver. > > When periodic mode is not enabled, it is neccessary to force reads. > > Signed-off-by: Pavel Machek > > diff --git

[PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-03 Thread Pavel Machek
For omap3, proper implementation of eocz bit is needed. It was actually a TODO in the driver. When periodic mode is not enabled, it is neccessary to force reads. Signed-off-by: Pavel Machek diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c

Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-03 Thread Pavel Machek
Hi! When periodic mode is not enabled, it is neccessary to force reads. Signed-off-by: Pavel Machek pa...@ucw.cz --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c @@ -43,6 +43,8 @@ #include ti-bandgap.h +static int

Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-03 Thread Eduardo Valentin
On Sat, Jan 03, 2015 at 12:46:32PM +0100, Pavel Machek wrote: For omap3, proper implementation of eocz bit is needed. It was actually a TODO in the driver. When periodic mode is not enabled, it is neccessary to force reads. Signed-off-by: Pavel Machek pa...@ucw.cz diff --git

[PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-03 Thread Pavel Machek
For omap3, proper implementation of eocz bit is needed. It was actually a TODO in the driver. When periodic mode is not enabled, it is neccessary to force reads. Signed-off-by: Pavel Machek pa...@ucw.cz diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c