Re: [PATCH] timer: Fix unsafe cpu variable access in migrate_timers

2015-06-27 Thread Borislav Petkov
On Sat, Jun 27, 2015 at 01:19:24PM +0200, Jan Kiszka wrote: > Oh, there is a fix already. It's just the same: both implicitly > disable preemption via get_cpu_ptr/var, look at the macros. Ah, yes. /me goes to the coffee machine to make eyes open. -- Regards/Gruss, Boris. ECO tip #101:

Re: [PATCH] timer: Fix unsafe cpu variable access in migrate_timers

2015-06-27 Thread Jan Kiszka
On 2015-06-27 13:00, Borislav Petkov wrote: > On Sat, Jun 27, 2015 at 11:55:49AM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> migrate_timers is invoked with preemption enabled. Therefore we have to >> get/put the cpu-local variable tvec_bases like before commit 0eeda71bc3. >> >> This fixes

Re: [PATCH] timer: Fix unsafe cpu variable access in migrate_timers

2015-06-27 Thread Borislav Petkov
On Sat, Jun 27, 2015 at 11:55:49AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > migrate_timers is invoked with preemption enabled. Therefore we have to > get/put the cpu-local variable tvec_bases like before commit 0eeda71bc3. > > This fixes > > BUG: using smp_processor_id() in preemptible

[PATCH] timer: Fix unsafe cpu variable access in migrate_timers

2015-06-27 Thread Jan Kiszka
From: Jan Kiszka migrate_timers is invoked with preemption enabled. Therefore we have to get/put the cpu-local variable tvec_bases like before commit 0eeda71bc3. This fixes BUG: using smp_processor_id() in preemptible [] code: bash/4917 caller is debug_smp_processor_id+0x17/0x19 CPU: 0

[PATCH] timer: Fix unsafe cpu variable access in migrate_timers

2015-06-27 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com migrate_timers is invoked with preemption enabled. Therefore we have to get/put the cpu-local variable tvec_bases like before commit 0eeda71bc3. This fixes BUG: using smp_processor_id() in preemptible [] code: bash/4917 caller is

Re: [PATCH] timer: Fix unsafe cpu variable access in migrate_timers

2015-06-27 Thread Borislav Petkov
On Sat, Jun 27, 2015 at 01:19:24PM +0200, Jan Kiszka wrote: Oh, there is a fix already. It's just the same: both implicitly disable preemption via get_cpu_ptr/var, look at the macros. Ah, yes. /me goes to the coffee machine to make eyes open. -- Regards/Gruss, Boris. ECO tip #101: Trim

Re: [PATCH] timer: Fix unsafe cpu variable access in migrate_timers

2015-06-27 Thread Borislav Petkov
On Sat, Jun 27, 2015 at 11:55:49AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com migrate_timers is invoked with preemption enabled. Therefore we have to get/put the cpu-local variable tvec_bases like before commit 0eeda71bc3. This fixes BUG: using smp_processor_id()

Re: [PATCH] timer: Fix unsafe cpu variable access in migrate_timers

2015-06-27 Thread Jan Kiszka
On 2015-06-27 13:00, Borislav Petkov wrote: On Sat, Jun 27, 2015 at 11:55:49AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com migrate_timers is invoked with preemption enabled. Therefore we have to get/put the cpu-local variable tvec_bases like before commit 0eeda71bc3.