Re: [PATCH] timer: mask unnecessary set of flags in do_init_timer

2020-08-13 Thread qianli zhao
Thomas Gleixner 于2020年8月13日周四 下午6:46写道: > > Qianli Zhao writes: > > Please start the first word after the colon with an upper case letter. > > > do_init_timer can specify flags of timer_list, > > Please write do_init_timer() so it's entirely clear that this is about a > function. > > > but this f

Re: [PATCH] timer: mask unnecessary set of flags in do_init_timer

2020-08-13 Thread Thomas Gleixner
Qianli Zhao writes: Please start the first word after the colon with an upper case letter. > do_init_timer can specify flags of timer_list, Please write do_init_timer() so it's entirely clear that this is about a function. > but this function does not expect to specify the CPU or idx. or idx

[PATCH] timer: mask unnecessary set of flags in do_init_timer

2020-08-06 Thread Qianli Zhao
From: Qianli Zhao do_init_timer can specify flags of timer_list, but this function does not expect to specify the CPU or idx. If user invoking do_init_timer and specify CPU, The result may not what we expected. E.g: do_init_timer invoked in core2,and specify flags 0x1 final result flags is 0x3.I