Re: [PATCH] tools lib api fs: Store tracing mountpoint for better error message

2015-09-19 Thread Raphaël Beamonte
2015-09-19 10:47 GMT-04:00 Jiri Olsa : > Storing the actual tracing path mountpoint to display correct > error message hint ('Hint:' line). The error hint rediscovers > mountpoints, but it could be different from what we actually > used in tracing path. > > Before we'd display debugfs mount even

Re: [PATCH] tools lib api fs: Store tracing mountpoint for better error message

2015-09-19 Thread Raphaël Beamonte
2015-09-19 11:00 GMT-04:00 Jiri Olsa : > On Sat, Sep 19, 2015 at 08:50:19AM -0600, David Ahern wrote: >> On 9/19/15 8:47 AM, Jiri Olsa wrote: >> >> >diff --git a/tools/lib/api/fs/tracing_path.c >> >b/tools/lib/api/fs/tracing_path.c >> >index 38aca2dd1946..0406a7d5c891 100644 >> >---

Re: [PATCH] tools lib api fs: Store tracing mountpoint for better error message

2015-09-19 Thread Jiri Olsa
On Sat, Sep 19, 2015 at 08:50:19AM -0600, David Ahern wrote: > On 9/19/15 8:47 AM, Jiri Olsa wrote: > > >diff --git a/tools/lib/api/fs/tracing_path.c > >b/tools/lib/api/fs/tracing_path.c > >index 38aca2dd1946..0406a7d5c891 100644 > >--- a/tools/lib/api/fs/tracing_path.c > >+++

Re: [PATCH] tools lib api fs: Store tracing mountpoint for better error message

2015-09-19 Thread David Ahern
On 9/19/15 8:47 AM, Jiri Olsa wrote: diff --git a/tools/lib/api/fs/tracing_path.c b/tools/lib/api/fs/tracing_path.c index 38aca2dd1946..0406a7d5c891 100644 --- a/tools/lib/api/fs/tracing_path.c +++ b/tools/lib/api/fs/tracing_path.c @@ -12,12 +12,14 @@ #include "tracing_path.h" +char

[PATCH] tools lib api fs: Store tracing mountpoint for better error message

2015-09-19 Thread Jiri Olsa
Storing the actual tracing path mountpoint to display correct error message hint ('Hint:' line). The error hint rediscovers mountpoints, but it could be different from what we actually used in tracing path. Before we'd display debugfs mount even though tracefs was used: $ perf record -e

[PATCH] tools lib api fs: Store tracing mountpoint for better error message

2015-09-19 Thread Jiri Olsa
Storing the actual tracing path mountpoint to display correct error message hint ('Hint:' line). The error hint rediscovers mountpoints, but it could be different from what we actually used in tracing path. Before we'd display debugfs mount even though tracefs was used: $ perf record -e

Re: [PATCH] tools lib api fs: Store tracing mountpoint for better error message

2015-09-19 Thread Raphaël Beamonte
2015-09-19 10:47 GMT-04:00 Jiri Olsa : > Storing the actual tracing path mountpoint to display correct > error message hint ('Hint:' line). The error hint rediscovers > mountpoints, but it could be different from what we actually > used in tracing path. > > Before we'd display

Re: [PATCH] tools lib api fs: Store tracing mountpoint for better error message

2015-09-19 Thread David Ahern
On 9/19/15 8:47 AM, Jiri Olsa wrote: diff --git a/tools/lib/api/fs/tracing_path.c b/tools/lib/api/fs/tracing_path.c index 38aca2dd1946..0406a7d5c891 100644 --- a/tools/lib/api/fs/tracing_path.c +++ b/tools/lib/api/fs/tracing_path.c @@ -12,12 +12,14 @@ #include "tracing_path.h" +char

Re: [PATCH] tools lib api fs: Store tracing mountpoint for better error message

2015-09-19 Thread Jiri Olsa
On Sat, Sep 19, 2015 at 08:50:19AM -0600, David Ahern wrote: > On 9/19/15 8:47 AM, Jiri Olsa wrote: > > >diff --git a/tools/lib/api/fs/tracing_path.c > >b/tools/lib/api/fs/tracing_path.c > >index 38aca2dd1946..0406a7d5c891 100644 > >--- a/tools/lib/api/fs/tracing_path.c > >+++

Re: [PATCH] tools lib api fs: Store tracing mountpoint for better error message

2015-09-19 Thread Raphaël Beamonte
2015-09-19 11:00 GMT-04:00 Jiri Olsa : > On Sat, Sep 19, 2015 at 08:50:19AM -0600, David Ahern wrote: >> On 9/19/15 8:47 AM, Jiri Olsa wrote: >> >> >diff --git a/tools/lib/api/fs/tracing_path.c >> >b/tools/lib/api/fs/tracing_path.c >> >index 38aca2dd1946..0406a7d5c891 100644 >>