Re: [PATCH] torture-test modules: Remove unnecessary "ret" variables

2018-09-26 Thread Paul E. McKenney
On Tue, Sep 25, 2018 at 02:47:08PM -0500, Pierce Griffiths wrote: > Paul, > The #ifdef cannot be replaced, as this would break the build for > CONFIG_HOTPLUG_CPU=n builds. There are assignments and references to two > global variables, a struct, and a function that are declared/defined in > a

Re: [PATCH] torture-test modules: Remove unnecessary "ret" variables

2018-09-26 Thread Paul E. McKenney
On Tue, Sep 25, 2018 at 02:47:08PM -0500, Pierce Griffiths wrote: > Paul, > The #ifdef cannot be replaced, as this would break the build for > CONFIG_HOTPLUG_CPU=n builds. There are assignments and references to two > global variables, a struct, and a function that are declared/defined in > a

Re: [PATCH] torture-test modules: Remove unnecessary "ret" variables

2018-09-25 Thread Pierce Griffiths
Paul, The #ifdef cannot be replaced, as this would break the build for CONFIG_HOTPLUG_CPU=n builds. There are assignments and references to two global variables, a struct, and a function that are declared/defined in a large "#ifdef CONFIG_HOTPLUG_CPU" block which ends directly above

Re: [PATCH] torture-test modules: Remove unnecessary "ret" variables

2018-09-25 Thread Pierce Griffiths
Paul, The #ifdef cannot be replaced, as this would break the build for CONFIG_HOTPLUG_CPU=n builds. There are assignments and references to two global variables, a struct, and a function that are declared/defined in a large "#ifdef CONFIG_HOTPLUG_CPU" block which ends directly above

Re: [PATCH] torture-test modules: Remove unnecessary "ret" variables

2018-09-22 Thread Paul E. McKenney
On Fri, Sep 21, 2018 at 08:21:31PM -0500, Pierce Griffiths wrote: > Remove return variables (declared as "ret") in cases where, > depending on whether a condition evaluates as true, the result of a > function call can be immediately returned instead of storing the result in > the return variable.

Re: [PATCH] torture-test modules: Remove unnecessary "ret" variables

2018-09-22 Thread Paul E. McKenney
On Fri, Sep 21, 2018 at 08:21:31PM -0500, Pierce Griffiths wrote: > Remove return variables (declared as "ret") in cases where, > depending on whether a condition evaluates as true, the result of a > function call can be immediately returned instead of storing the result in > the return variable.

[PATCH] torture-test modules: Remove unnecessary "ret" variables

2018-09-21 Thread Pierce Griffiths
Remove return variables (declared as "ret") in cases where, depending on whether a condition evaluates as true, the result of a function call can be immediately returned instead of storing the result in the return variable. When the condition evaluates as false, the constant initially stored in

[PATCH] torture-test modules: Remove unnecessary "ret" variables

2018-09-21 Thread Pierce Griffiths
Remove return variables (declared as "ret") in cases where, depending on whether a condition evaluates as true, the result of a function call can be immediately returned instead of storing the result in the return variable. When the condition evaluates as false, the constant initially stored in