Re: [PATCH] trace: reenable preemption if we modify the ip

2017-12-17 Thread Masami Hiramatsu
On Fri, 15 Dec 2017 21:42:57 -0500 Josef Bacik wrote: > From: Josef Bacik > > Things got moved around between the original bpf_override_return patches > and the final version, and now the ftrace kprobe dispatcher assumes if > you modified the ip that you

Re: [PATCH] trace: reenable preemption if we modify the ip

2017-12-17 Thread Masami Hiramatsu
On Fri, 15 Dec 2017 21:42:57 -0500 Josef Bacik wrote: > From: Josef Bacik > > Things got moved around between the original bpf_override_return patches > and the final version, and now the ftrace kprobe dispatcher assumes if > you modified the ip that you also enabled preemption. Make a

Re: [PATCH] trace: reenable preemption if we modify the ip

2017-12-17 Thread Daniel Borkmann
On 12/16/2017 03:42 AM, Josef Bacik wrote: > From: Josef Bacik > > Things got moved around between the original bpf_override_return patches > and the final version, and now the ftrace kprobe dispatcher assumes if > you modified the ip that you also enabled preemption. Make a

Re: [PATCH] trace: reenable preemption if we modify the ip

2017-12-17 Thread Daniel Borkmann
On 12/16/2017 03:42 AM, Josef Bacik wrote: > From: Josef Bacik > > Things got moved around between the original bpf_override_return patches > and the final version, and now the ftrace kprobe dispatcher assumes if > you modified the ip that you also enabled preemption. Make a comment of > this

[PATCH] trace: reenable preemption if we modify the ip

2017-12-15 Thread Josef Bacik
From: Josef Bacik Things got moved around between the original bpf_override_return patches and the final version, and now the ftrace kprobe dispatcher assumes if you modified the ip that you also enabled preemption. Make a comment of this and enable preemption, this fixes the

[PATCH] trace: reenable preemption if we modify the ip

2017-12-15 Thread Josef Bacik
From: Josef Bacik Things got moved around between the original bpf_override_return patches and the final version, and now the ftrace kprobe dispatcher assumes if you modified the ip that you also enabled preemption. Make a comment of this and enable preemption, this fixes the lockdep splat that