Re: [PATCH] tty/serial: atmel: remove unneeded atmel_get_lines_status function

2019-08-25 Thread Greg Kroah-Hartman
On Fri, Aug 23, 2019 at 04:32:41PM +0200, Uwe Kleine-König wrote: > On Fri, Aug 23, 2019 at 03:41:09PM +0200, Richard Genoud wrote: > > Since commit ce59e48fdbad ("serial: mctrl_gpio: implement interrupt > > handling"), the GPIOs interrupts are handled by mctrl_gpio_irq_handle(). > > Well no,

Re: [PATCH] tty/serial: atmel: remove unneeded atmel_get_lines_status function

2019-08-23 Thread Uwe Kleine-König
On Fri, Aug 23, 2019 at 03:41:09PM +0200, Richard Genoud wrote: > Since commit ce59e48fdbad ("serial: mctrl_gpio: implement interrupt > handling"), the GPIOs interrupts are handled by mctrl_gpio_irq_handle(). Well no, since ce59e48fdbad the mctrl_gpio helper can do all that interrupt stuff. You

[PATCH] tty/serial: atmel: remove unneeded atmel_get_lines_status function

2019-08-23 Thread Richard Genoud
Since commit ce59e48fdbad ("serial: mctrl_gpio: implement interrupt handling"), the GPIOs interrupts are handled by mctrl_gpio_irq_handle(). So, atmel_get_lines_status() can be completely killed and replaced by : atmel_uart_readl(port, ATMEL_US_CSR); Signed-off-by: Richard Genoud ---