Re: [PATCH] tty: fix data race in tty_buffer_flush

2015-09-17 Thread Greg Kroah-Hartman
On Thu, Sep 17, 2015 at 12:28:11PM +0200, Dmitry Vyukov wrote: > One stupid question. There is a number of branches: > remotes/origin/master > remotes/origin/tty-linus > remotes/origin/tty-next > remotes/origin/tty-testing > > What branch should I base my patches on? I used master. Right

Re: [PATCH] tty: fix data race in tty_buffer_flush

2015-09-17 Thread Dmitry Vyukov
sibility over the buffer before freeing it. >>>> >>>> The data race was found with KernelThreadSanitizer (KTSAN). >>> >>> Dmitry, >>> >>> Looks good. Thanks for splitting this from the other fix. >>> >>> Like Greg said

Re: [PATCH] tty: fix data race in tty_buffer_flush

2015-09-17 Thread Dmitry Vyukov
rom the other fix. >> >> Like Greg said, the patch needs revision info to help maintainers, et al >> track which is most current/relevant/etc. >> >> Typical format for $subject is something like: >> >> [PATCH v4] tty: fix data race in tty_buffer_flush >>

Re: [PATCH] tty: fix data race in tty_buffer_flush

2015-09-17 Thread Dmitry Vyukov
t;> >> Dmitry, >> >> Looks good. Thanks for splitting this from the other fix. >> >> Like Greg said, the patch needs revision info to help maintainers, et al >> track which is most current/relevant/etc. >> >> Typical format for $subject is something like: &

Re: [PATCH] tty: fix data race in tty_buffer_flush

2015-09-17 Thread Dmitry Vyukov
;>> Looks good. Thanks for splitting this from the other fix. >>> >>> Like Greg said, the patch needs revision info to help maintainers, et al >>> track which is most current/relevant/etc. >>> >>> Typical format for $subject is something like: >&g

Re: [PATCH] tty: fix data race in tty_buffer_flush

2015-09-17 Thread Greg Kroah-Hartman
On Thu, Sep 17, 2015 at 12:28:11PM +0200, Dmitry Vyukov wrote: > One stupid question. There is a number of branches: > remotes/origin/master > remotes/origin/tty-linus > remotes/origin/tty-next > remotes/origin/tty-testing > > What branch should I base my patches on? I used master. Right

Re: [PATCH] tty: fix data race in tty_buffer_flush

2015-09-16 Thread Dmitry Vyukov
o to help maintainers, et al > track which is most current/relevant/etc. > > Typical format for $subject is something like: > > [PATCH v4] tty: fix data race in tty_buffer_flush > > > Notes re: changes from other patch versions are added below the > git changelog separ

Re: [PATCH] tty: fix data race in tty_buffer_flush

2015-09-16 Thread Dmitry Vyukov
fix. > > Like Greg said, the patch needs revision info to help maintainers, et al > track which is most current/relevant/etc. > > Typical format for $subject is something like: > > [PATCH v4] tty: fix data race in tty_buffer_flush > > > Notes re: changes from oth

Re: [PATCH] tty: fix data race in tty_buffer_flush

2015-09-15 Thread Peter Hurley
om the other fix. Like Greg said, the patch needs revision info to help maintainers, et al track which is most current/relevant/etc. Typical format for $subject is something like: [PATCH v4] tty: fix data race in tty_buffer_flush Notes re: changes from other patch versions are added below the

Re: [PATCH] tty: fix data race in tty_buffer_flush

2015-09-15 Thread Peter Hurley
hanks for splitting this from the other fix. Like Greg said, the patch needs revision info to help maintainers, et al track which is most current/relevant/etc. Typical format for $subject is something like: [PATCH v4] tty: fix data race in tty_buffer_flush Notes re: changes from other patch ver

Re: [PATCH] tty: fix data race in tty_buffer_flush

2015-09-08 Thread Greg KH
On Tue, Sep 08, 2015 at 02:48:26PM +0200, Dmitry Vyukov wrote: > tty_buffer_flush frees not acquired buffers. > As the result, for example, read of b->size in tty_buffer_free > can return garbage value which will lead to a huge buffer > hanging in the freelist. This is just the benignest >

[PATCH] tty: fix data race in tty_buffer_flush

2015-09-08 Thread Dmitry Vyukov
tty_buffer_flush frees not acquired buffers. As the result, for example, read of b->size in tty_buffer_free can return garbage value which will lead to a huge buffer hanging in the freelist. This is just the benignest manifestation of freeing of a not acquired object. If the object is passed to

[PATCH] tty: fix data race in tty_buffer_flush

2015-09-08 Thread Dmitry Vyukov
tty_buffer_flush frees not acquired buffers. As the result, for example, read of b->size in tty_buffer_free can return garbage value which will lead to a huge buffer hanging in the freelist. This is just the benignest manifestation of freeing of a not acquired object. If the object is passed to

Re: [PATCH] tty: fix data race in tty_buffer_flush

2015-09-08 Thread Greg KH
On Tue, Sep 08, 2015 at 02:48:26PM +0200, Dmitry Vyukov wrote: > tty_buffer_flush frees not acquired buffers. > As the result, for example, read of b->size in tty_buffer_free > can return garbage value which will lead to a huge buffer > hanging in the freelist. This is just the benignest >

[PATCH] tty: fix data race in tty_buffer_flush

2015-09-07 Thread Dmitry Vyukov
tty_buffer_flush frees not acquired buffers. As the result, for example, read of b->size in tty_buffer_free can return garbage value which will lead to a huge buffer hanging in the freelist. This is just the benignest manifestation of freeing of a not acquired object. If the object is passed to

[PATCH] tty: fix data race in tty_buffer_flush

2015-09-07 Thread Dmitry Vyukov
tty_buffer_flush frees not acquired buffers. As the result, for example, read of b->size in tty_buffer_free can return garbage value which will lead to a huge buffer hanging in the freelist. This is just the benignest manifestation of freeing of a not acquired object. If the object is passed to