Re: [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ

2020-11-21 Thread Johan Hovold
On Fri, Nov 20, 2020 at 08:00:05PM +, David Laight wrote: > From: Johan Hovold > > Sent: 20 November 2020 12:50 > > > > On Fri, Nov 20, 2020 at 07:25:03PM +0800, tiantao (H) wrote: > > > 在 2020/11/20 16:23, Johan Hovold 写道: > > > > On Thu, Nov 19, 2020 at 05:01:29PM +0800, Tian Tao wrote: > >

RE: [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ

2020-11-20 Thread David Laight
From: Johan Hovold > Sent: 20 November 2020 12:50 > > On Fri, Nov 20, 2020 at 07:25:03PM +0800, tiantao (H) wrote: > > 在 2020/11/20 16:23, Johan Hovold 写道: > > > On Thu, Nov 19, 2020 at 05:01:29PM +0800, Tian Tao wrote: > > >> The code has been in a irq-disabled context since it is hard IRQ.

Re: [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ

2020-11-20 Thread Johan Hovold
On Fri, Nov 20, 2020 at 07:25:03PM +0800, tiantao (H) wrote: > 在 2020/11/20 16:23, Johan Hovold 写道: > > On Thu, Nov 19, 2020 at 05:01:29PM +0800, Tian Tao wrote: > >> The code has been in a irq-disabled context since it is hard IRQ. There > >> is no necessity to do it again. > >> > >>

Re: [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ

2020-11-20 Thread tiantao (H)
在 2020/11/20 16:23, Johan Hovold 写道: On Thu, Nov 19, 2020 at 05:01:29PM +0800, Tian Tao wrote: The code has been in a irq-disabled context since it is hard IRQ. There is no necessity to do it again. Signed-off-by: Tian Tao --- drivers/tty/serial/owl-uart.c | 5 ++--- 1 file changed, 2

Re: [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ

2020-11-20 Thread Johan Hovold
On Thu, Nov 19, 2020 at 05:01:29PM +0800, Tian Tao wrote: > The code has been in a irq-disabled context since it is hard IRQ. There > is no necessity to do it again. > > Signed-off-by: Tian Tao > --- > drivers/tty/serial/owl-uart.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >

Re: [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ

2020-11-19 Thread Jiri Slaby
On 19. 11. 20, 10:01, Tian Tao wrote: The code has been in a irq-disabled context since it is hard IRQ. There is no necessity to do it again. Signed-off-by: Tian Tao Reviewed-by: Jiri Slaby --- drivers/tty/serial/owl-uart.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ

2020-11-19 Thread Tian Tao
The code has been in a irq-disabled context since it is hard IRQ. There is no necessity to do it again. Signed-off-by: Tian Tao --- drivers/tty/serial/owl-uart.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/owl-uart.c