Re: [PATCH] tun: don't zeroize sock->file on detach

2012-08-22 Thread Stanislav Kinsbursky
21.08.2012 21:18, Neal Cardwell пишет: On Tue, Aug 21, 2012 at 12:04 PM, Stanislav Kinsbursky wrote: 10.08.2012 03:16, David Miller пишет: From: Stanislav Kinsbursky Date: Thu, 09 Aug 2012 16:50:40 +0400 This is a fix for bug, introduced in 3.4 kernel by commit

Re: [PATCH] tun: don't zeroize sock-file on detach

2012-08-22 Thread Stanislav Kinsbursky
21.08.2012 21:18, Neal Cardwell пишет: On Tue, Aug 21, 2012 at 12:04 PM, Stanislav Kinsbursky skinsbur...@parallels.com wrote: 10.08.2012 03:16, David Miller пишет: From: Stanislav Kinsbursky skinsbur...@parallels.com Date: Thu, 09 Aug 2012 16:50:40 +0400 This is a fix for bug, introduced

Re: [PATCH] tun: don't zeroize sock->file on detach

2012-08-21 Thread Neal Cardwell
On Tue, Aug 21, 2012 at 12:04 PM, Stanislav Kinsbursky wrote: > 10.08.2012 03:16, David Miller пишет: > >> From: Stanislav Kinsbursky >> Date: Thu, 09 Aug 2012 16:50:40 +0400 >> >>> This is a fix for bug, introduced in 3.4 kernel by commit >>> 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which,

Re: [PATCH] tun: don't zeroize sock->file on detach

2012-08-21 Thread Stanislav Kinsbursky
10.08.2012 03:16, David Miller пишет: From: Stanislav Kinsbursky Date: Thu, 09 Aug 2012 16:50:40 +0400 This is a fix for bug, introduced in 3.4 kernel by commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced simple sock_put() by sk_release_kernel(). Below is

Re: [PATCH] tun: don't zeroize sock-file on detach

2012-08-21 Thread Stanislav Kinsbursky
10.08.2012 03:16, David Miller пишет: From: Stanislav Kinsbursky skinsbur...@parallels.com Date: Thu, 09 Aug 2012 16:50:40 +0400 This is a fix for bug, introduced in 3.4 kernel by commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced simple sock_put() by

Re: [PATCH] tun: don't zeroize sock-file on detach

2012-08-21 Thread Neal Cardwell
On Tue, Aug 21, 2012 at 12:04 PM, Stanislav Kinsbursky skinsbur...@parallels.com wrote: 10.08.2012 03:16, David Miller пишет: From: Stanislav Kinsbursky skinsbur...@parallels.com Date: Thu, 09 Aug 2012 16:50:40 +0400 This is a fix for bug, introduced in 3.4 kernel by commit

Re: [PATCH] tun: don't zeroize sock->file on detach

2012-08-09 Thread David Miller
From: Stanislav Kinsbursky Date: Thu, 09 Aug 2012 16:50:40 +0400 > This is a fix for bug, introduced in 3.4 kernel by commit > 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced > simple sock_put() by sk_release_kernel(). Below is sequence, which leads to > oops for

[PATCH] tun: don't zeroize sock->file on detach

2012-08-09 Thread Stanislav Kinsbursky
This is a fix for bug, introduced in 3.4 kernel by commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced simple sock_put() by sk_release_kernel(). Below is sequence, which leads to oops for non-persistent devices: tun_chr_close() tun_detach()

[PATCH] tun: don't zeroize sock-file on detach

2012-08-09 Thread Stanislav Kinsbursky
This is a fix for bug, introduced in 3.4 kernel by commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced simple sock_put() by sk_release_kernel(). Below is sequence, which leads to oops for non-persistent devices: tun_chr_close() tun_detach()

Re: [PATCH] tun: don't zeroize sock-file on detach

2012-08-09 Thread David Miller
From: Stanislav Kinsbursky skinsbur...@parallels.com Date: Thu, 09 Aug 2012 16:50:40 +0400 This is a fix for bug, introduced in 3.4 kernel by commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced simple sock_put() by sk_release_kernel(). Below is sequence, which

Re: [RFC PATCH] tun: don't zeroize sock->file on detach

2012-08-08 Thread David Miller
From: Yuchung Cheng Date: Wed, 8 Aug 2012 10:48:32 -0700 > On Wed, Aug 8, 2012 at 5:53 AM, Stanislav Kinsbursky > wrote: >> Hi, Dave. >> What about this patch? >> >> >> On Wed, Jul 11, 2012 at 03:48:20PM +0400, Stanislav Kinsbursky wrote: >>> >>> This is a fix for bug, introduced in 3.4 kernel

Re: [RFC PATCH] tun: don't zeroize sock->file on detach

2012-08-08 Thread Yuchung Cheng
On Wed, Aug 8, 2012 at 5:53 AM, Stanislav Kinsbursky wrote: > Hi, Dave. > What about this patch? > > > On Wed, Jul 11, 2012 at 03:48:20PM +0400, Stanislav Kinsbursky wrote: >> >> This is a fix for bug, introduced in 3.4 kernel by commit >> 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among

Re: [RFC PATCH] tun: don't zeroize sock->file on detach

2012-08-08 Thread Stanislav Kinsbursky
Hi, Dave. What about this patch? On Wed, Jul 11, 2012 at 03:48:20PM +0400, Stanislav Kinsbursky wrote: This is a fix for bug, introduced in 3.4 kernel by commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced simple sock_put() by sk_release_kernel(). Below is

Re: [RFC PATCH] tun: don't zeroize sock-file on detach

2012-08-08 Thread Stanislav Kinsbursky
Hi, Dave. What about this patch? On Wed, Jul 11, 2012 at 03:48:20PM +0400, Stanislav Kinsbursky wrote: This is a fix for bug, introduced in 3.4 kernel by commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced simple sock_put() by sk_release_kernel(). Below is

Re: [RFC PATCH] tun: don't zeroize sock-file on detach

2012-08-08 Thread Yuchung Cheng
On Wed, Aug 8, 2012 at 5:53 AM, Stanislav Kinsbursky skinsbur...@parallels.com wrote: Hi, Dave. What about this patch? On Wed, Jul 11, 2012 at 03:48:20PM +0400, Stanislav Kinsbursky wrote: This is a fix for bug, introduced in 3.4 kernel by commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d,

Re: [RFC PATCH] tun: don't zeroize sock-file on detach

2012-08-08 Thread David Miller
From: Yuchung Cheng ych...@google.com Date: Wed, 8 Aug 2012 10:48:32 -0700 On Wed, Aug 8, 2012 at 5:53 AM, Stanislav Kinsbursky skinsbur...@parallels.com wrote: Hi, Dave. What about this patch? On Wed, Jul 11, 2012 at 03:48:20PM +0400, Stanislav Kinsbursky wrote: This is a fix for bug,

Re: [RFC PATCH] tun: don't zeroize sock->file on detach

2012-07-19 Thread Eric Dumazet
On Wed, 2012-07-11 at 15:48 +0400, Stanislav Kinsbursky wrote: > This is a fix for bug, introduced in 3.4 kernel by commit > 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced > simple sock_put() by sk_release_kernel(). Below is sequence, which leads to > oops for

Re: [RFC PATCH] tun: don't zeroize sock-file on detach

2012-07-19 Thread Eric Dumazet
On Wed, 2012-07-11 at 15:48 +0400, Stanislav Kinsbursky wrote: This is a fix for bug, introduced in 3.4 kernel by commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced simple sock_put() by sk_release_kernel(). Below is sequence, which leads to oops for

Re: [RFC PATCH] tun: don't zeroize sock->file on detach

2012-07-14 Thread Al Viro
On Wed, Jul 11, 2012 at 03:48:20PM +0400, Stanislav Kinsbursky wrote: > This is a fix for bug, introduced in 3.4 kernel by commit > 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced > simple sock_put() by sk_release_kernel(). Below is sequence, which leads to > oops for

Re: [RFC PATCH] tun: don't zeroize sock-file on detach

2012-07-14 Thread Al Viro
On Wed, Jul 11, 2012 at 03:48:20PM +0400, Stanislav Kinsbursky wrote: This is a fix for bug, introduced in 3.4 kernel by commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced simple sock_put() by sk_release_kernel(). Below is sequence, which leads to oops for

[RFC PATCH] tun: don't zeroize sock->file on detach

2012-07-11 Thread Stanislav Kinsbursky
This is a fix for bug, introduced in 3.4 kernel by commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced simple sock_put() by sk_release_kernel(). Below is sequence, which leads to oops for non-persistent devices: tun_chr_close() tun_detach()

[RFC PATCH] tun: don't zeroize sock-file on detach

2012-07-11 Thread Stanislav Kinsbursky
This is a fix for bug, introduced in 3.4 kernel by commit 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced simple sock_put() by sk_release_kernel(). Below is sequence, which leads to oops for non-persistent devices: tun_chr_close() tun_detach()