Re: [PATCH] uaccess: Add missing __must_check attributes

2019-10-01 Thread Arnd Bergmann
On Tue, Oct 1, 2019 at 1:17 AM Kees Cook wrote: > On Mon, Sep 30, 2019 at 12:33:19PM +0200, Arnd Bergmann wrote: > > On Wed, Aug 28, 2019 at 7:38 PM Kees Cook wrote: > > arch/x86/math-emu/reg_ld_str.c:88:2: error: ignoring return value of > > function declared with 'warn_unused_result' attribute

Re: [PATCH] uaccess: Add missing __must_check attributes

2019-09-30 Thread Kees Cook
On Mon, Sep 30, 2019 at 12:33:19PM +0200, Arnd Bergmann wrote: > On Wed, Aug 28, 2019 at 7:38 PM Kees Cook wrote: > > > > The usercopy implementation comments describe that callers of the > > copy_*_user() family of functions must always have their return values > > checked. This can be enforced a

Re: [PATCH] uaccess: Add missing __must_check attributes

2019-09-30 Thread Arnd Bergmann
On Wed, Aug 28, 2019 at 7:38 PM Kees Cook wrote: > > The usercopy implementation comments describe that callers of the > copy_*_user() family of functions must always have their return values > checked. This can be enforced at compile time with __must_check, so add > it where needed. > > Signed-of

[PATCH] uaccess: Add missing __must_check attributes

2019-08-28 Thread Kees Cook
The usercopy implementation comments describe that callers of the copy_*_user() family of functions must always have their return values checked. This can be enforced at compile time with __must_check, so add it where needed. Signed-off-by: Kees Cook --- include/linux/thread_info.h | 2 +- incl