Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness

2014-12-18 Thread Nicholas A. Bellinger
Hi Kyle, On Thu, 2014-12-18 at 12:57 -0500, Kyle McMartin wrote: > scripts/headers_install.sh will transform __packed to > __attribute__((packed)), so the #ifndef is not necessary. > (and, in fact, it's problematic, because we'll end up with the header > containing: > #ifndef

Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness

2014-12-18 Thread Andy Grover
On 12/18/2014 09:57 AM, Kyle McMartin wrote: scripts/headers_install.sh will transform __packed to __attribute__((packed)), so the #ifndef is not necessary. (and, in fact, it's problematic, because we'll end up with the header containing: #ifndef __attribute__((packed)) #define __attribu...

[PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness

2014-12-18 Thread Kyle McMartin
scripts/headers_install.sh will transform __packed to __attribute__((packed)), so the #ifndef is not necessary. (and, in fact, it's problematic, because we'll end up with the header containing: #ifndef __attribute__((packed)) #define __attribu... and so forth.) Cc: sta...@vger.kernel.org # 3.18

[PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness

2014-12-18 Thread Kyle McMartin
scripts/headers_install.sh will transform __packed to __attribute__((packed)), so the #ifndef is not necessary. (and, in fact, it's problematic, because we'll end up with the header containing: #ifndef __attribute__((packed)) #define __attribu... and so forth.) Cc: sta...@vger.kernel.org # 3.18

Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness

2014-12-18 Thread Andy Grover
On 12/18/2014 09:57 AM, Kyle McMartin wrote: scripts/headers_install.sh will transform __packed to __attribute__((packed)), so the #ifndef is not necessary. (and, in fact, it's problematic, because we'll end up with the header containing: #ifndef __attribute__((packed)) #define __attribu...

Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness

2014-12-18 Thread Nicholas A. Bellinger
Hi Kyle, On Thu, 2014-12-18 at 12:57 -0500, Kyle McMartin wrote: scripts/headers_install.sh will transform __packed to __attribute__((packed)), so the #ifndef is not necessary. (and, in fact, it's problematic, because we'll end up with the header containing: #ifndef __attribute__((packed))