Re: [PATCH] ubi: avoid workqueue format string leak

2014-04-08 Thread Ezequiel Garcia
On Apr 08, Kees Cook wrote: > On Tue, Apr 8, 2014 at 7:43 AM, Artem Bityutskiy > wrote: > > On Tue, 2014-04-08 at 10:57 -0300, Ezequiel Garcia wrote: > >> Hello Kees, > >> > >> Thanks for the patch. > >> > >> On Apr 07, Kees Cook wrote: > >> > When building the name for the workqueue thread, make

Re: [PATCH] ubi: avoid workqueue format string leak

2014-04-08 Thread Kees Cook
On Tue, Apr 8, 2014 at 7:43 AM, Artem Bityutskiy wrote: > On Tue, 2014-04-08 at 10:57 -0300, Ezequiel Garcia wrote: >> Hello Kees, >> >> Thanks for the patch. >> >> On Apr 07, Kees Cook wrote: >> > When building the name for the workqueue thread, make sure a format >> > string cannot leak in from

Re: [PATCH] ubi: avoid workqueue format string leak

2014-04-08 Thread Artem Bityutskiy
On Tue, 2014-04-08 at 10:57 -0300, Ezequiel Garcia wrote: > Hello Kees, > > Thanks for the patch. > > On Apr 07, Kees Cook wrote: > > When building the name for the workqueue thread, make sure a format > > string cannot leak in from the disk name. > > > > Could you enlighten me and explain why

Re: [PATCH] ubi: avoid workqueue format string leak

2014-04-08 Thread Artem Bityutskiy
On Mon, 2014-04-07 at 21:44 -0700, Kees Cook wrote: > When building the name for the workqueue thread, make sure a format > string cannot leak in from the disk name. > > Signed-off-by: Kees Cook Pushed to linux-ubifs / master, thanks! -- Best Regards, Artem Bityutskiy -- To unsubscribe from

Re: [PATCH] ubi: avoid workqueue format string leak

2014-04-08 Thread Ezequiel Garcia
Hello Kees, Thanks for the patch. On Apr 07, Kees Cook wrote: > When building the name for the workqueue thread, make sure a format > string cannot leak in from the disk name. > Could you enlighten me and explain why you want to avoid the name leak? Is it a security concern? I'd like to

Re: [PATCH] ubi: avoid workqueue format string leak

2014-04-08 Thread Ezequiel Garcia
Hello Kees, Thanks for the patch. On Apr 07, Kees Cook wrote: When building the name for the workqueue thread, make sure a format string cannot leak in from the disk name. Could you enlighten me and explain why you want to avoid the name leak? Is it a security concern? I'd like to

Re: [PATCH] ubi: avoid workqueue format string leak

2014-04-08 Thread Artem Bityutskiy
On Mon, 2014-04-07 at 21:44 -0700, Kees Cook wrote: When building the name for the workqueue thread, make sure a format string cannot leak in from the disk name. Signed-off-by: Kees Cook keesc...@chromium.org Pushed to linux-ubifs / master, thanks! -- Best Regards, Artem Bityutskiy -- To

Re: [PATCH] ubi: avoid workqueue format string leak

2014-04-08 Thread Artem Bityutskiy
On Tue, 2014-04-08 at 10:57 -0300, Ezequiel Garcia wrote: Hello Kees, Thanks for the patch. On Apr 07, Kees Cook wrote: When building the name for the workqueue thread, make sure a format string cannot leak in from the disk name. Could you enlighten me and explain why you want to

Re: [PATCH] ubi: avoid workqueue format string leak

2014-04-08 Thread Kees Cook
On Tue, Apr 8, 2014 at 7:43 AM, Artem Bityutskiy artem.bityuts...@linux.intel.com wrote: On Tue, 2014-04-08 at 10:57 -0300, Ezequiel Garcia wrote: Hello Kees, Thanks for the patch. On Apr 07, Kees Cook wrote: When building the name for the workqueue thread, make sure a format string

Re: [PATCH] ubi: avoid workqueue format string leak

2014-04-08 Thread Ezequiel Garcia
On Apr 08, Kees Cook wrote: On Tue, Apr 8, 2014 at 7:43 AM, Artem Bityutskiy artem.bityuts...@linux.intel.com wrote: On Tue, 2014-04-08 at 10:57 -0300, Ezequiel Garcia wrote: Hello Kees, Thanks for the patch. On Apr 07, Kees Cook wrote: When building the name for the workqueue

[PATCH] ubi: avoid workqueue format string leak

2014-04-07 Thread Kees Cook
When building the name for the workqueue thread, make sure a format string cannot leak in from the disk name. Signed-off-by: Kees Cook --- drivers/mtd/ubi/block.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c index

[PATCH] ubi: avoid workqueue format string leak

2014-04-07 Thread Kees Cook
When building the name for the workqueue thread, make sure a format string cannot leak in from the disk name. Signed-off-by: Kees Cook keesc...@chromium.org --- drivers/mtd/ubi/block.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/ubi/block.c