Re: [PATCH] ufs: qcom: Properly clear hba priv on failure

2016-11-21 Thread Subhash Jadavani
On 2016-11-19 22:15, Bjorn Andersson wrote: On Sat 19 Nov 12:30 PST 2016, Subhash Jadavani wrote: On 2016-11-18 12:55, Bjorn Andersson wrote: >In the case where we fail to acquire the phy the hba priv will be set >already, so during cleanup ufs_qcom_setup_clocks() will dereference the >now

Re: [PATCH] ufs: qcom: Properly clear hba priv on failure

2016-11-21 Thread Subhash Jadavani
On 2016-11-19 22:15, Bjorn Andersson wrote: On Sat 19 Nov 12:30 PST 2016, Subhash Jadavani wrote: On 2016-11-18 12:55, Bjorn Andersson wrote: >In the case where we fail to acquire the phy the hba priv will be set >already, so during cleanup ufs_qcom_setup_clocks() will dereference the >now

Re: [PATCH] ufs: qcom: Properly clear hba priv on failure

2016-11-19 Thread Bjorn Andersson
On Sat 19 Nov 12:30 PST 2016, Subhash Jadavani wrote: > On 2016-11-18 12:55, Bjorn Andersson wrote: > >In the case where we fail to acquire the phy the hba priv will be set > >already, so during cleanup ufs_qcom_setup_clocks() will dereference the > >now free, but still "valid looking" pointer

Re: [PATCH] ufs: qcom: Properly clear hba priv on failure

2016-11-19 Thread Bjorn Andersson
On Sat 19 Nov 12:30 PST 2016, Subhash Jadavani wrote: > On 2016-11-18 12:55, Bjorn Andersson wrote: > >In the case where we fail to acquire the phy the hba priv will be set > >already, so during cleanup ufs_qcom_setup_clocks() will dereference the > >now free, but still "valid looking" pointer

Re: [PATCH] ufs: qcom: Properly clear hba priv on failure

2016-11-19 Thread Subhash Jadavani
On 2016-11-18 12:55, Bjorn Andersson wrote: In the case where we fail to acquire the phy the hba priv will be set already, so during cleanup ufs_qcom_setup_clocks() will dereference the now free, but still "valid looking" pointer "host". host (ufs_qcom_host) was allocated with devm_kzalloc()

Re: [PATCH] ufs: qcom: Properly clear hba priv on failure

2016-11-19 Thread Subhash Jadavani
On 2016-11-18 12:55, Bjorn Andersson wrote: In the case where we fail to acquire the phy the hba priv will be set already, so during cleanup ufs_qcom_setup_clocks() will dereference the now free, but still "valid looking" pointer "host". host (ufs_qcom_host) was allocated with devm_kzalloc()

[PATCH] ufs: qcom: Properly clear hba priv on failure

2016-11-18 Thread Bjorn Andersson
In the case where we fail to acquire the phy the hba priv will be set already, so during cleanup ufs_qcom_setup_clocks() will dereference the now free, but still "valid looking" pointer "host". Signed-off-by: Bjorn Andersson --- drivers/scsi/ufs/ufs-qcom.c | 2 +- 1

[PATCH] ufs: qcom: Properly clear hba priv on failure

2016-11-18 Thread Bjorn Andersson
In the case where we fail to acquire the phy the hba priv will be set already, so during cleanup ufs_qcom_setup_clocks() will dereference the now free, but still "valid looking" pointer "host". Signed-off-by: Bjorn Andersson --- drivers/scsi/ufs/ufs-qcom.c | 2 +- 1 file changed, 1