Re: [PATCH] uprobes: introduce arch_uprobe->ixol

2013-11-05 Thread David Long
On 11/05/13 13:01, Oleg Nesterov wrote: On 11/05, David Long wrote: On 11/04/13 14:49, Oleg Nesterov wrote: On 10/29, Oleg Nesterov wrote: Seriouly, how about the patch below? In fact, given that you are going to reimplement set_swbp/orig_insn, the new member is not strictly needed

Re: [PATCH] uprobes: introduce arch_uprobe->ixol

2013-11-05 Thread Oleg Nesterov
On 11/05, David Long wrote: > > On 11/04/13 14:49, Oleg Nesterov wrote: >> On 10/29, Oleg Nesterov wrote: >>> >> Seriouly, how about the patch below? >> >> In fact, given that you are going to reimplement set_swbp/orig_insn, >> the new member is not strictly needed (afaics). But it looks more >>

Re: [PATCH] uprobes: introduce arch_uprobe->ixol

2013-11-05 Thread David Long
On 11/04/13 14:49, Oleg Nesterov wrote: On 10/29, Oleg Nesterov wrote: David. Perhaps we can avoid the new hook altogether? What if we do the simple change below (it ignores powerpc) ? Then arm can add "unsigned long ixol[2]" into its arch_uprobe, and arch_uprobe_analyze_insn() can initialize

Re: [PATCH] uprobes: introduce arch_uprobe-ixol

2013-11-05 Thread David Long
On 11/04/13 14:49, Oleg Nesterov wrote: On 10/29, Oleg Nesterov wrote: David. Perhaps we can avoid the new hook altogether? What if we do the simple change below (it ignores powerpc) ? Then arm can add unsigned long ixol[2] into its arch_uprobe, and arch_uprobe_analyze_insn() can initialize

Re: [PATCH] uprobes: introduce arch_uprobe-ixol

2013-11-05 Thread Oleg Nesterov
On 11/05, David Long wrote: On 11/04/13 14:49, Oleg Nesterov wrote: On 10/29, Oleg Nesterov wrote: Seriouly, how about the patch below? In fact, given that you are going to reimplement set_swbp/orig_insn, the new member is not strictly needed (afaics). But it looks more clear this way,

Re: [PATCH] uprobes: introduce arch_uprobe-ixol

2013-11-05 Thread David Long
On 11/05/13 13:01, Oleg Nesterov wrote: On 11/05, David Long wrote: On 11/04/13 14:49, Oleg Nesterov wrote: On 10/29, Oleg Nesterov wrote: Seriouly, how about the patch below? In fact, given that you are going to reimplement set_swbp/orig_insn, the new member is not strictly needed

Re: [PATCH] uprobes: introduce arch_uprobe->ixol

2013-11-04 Thread David Long
On 11/04/13 14:49, Oleg Nesterov wrote: On 10/29, Oleg Nesterov wrote: David. Perhaps we can avoid the new hook altogether? What if we do the simple change below (it ignores powerpc) ? Then arm can add "unsigned long ixol[2]" into its arch_uprobe, and arch_uprobe_analyze_insn() can initialize

[PATCH] uprobes: introduce arch_uprobe->ixol

2013-11-04 Thread Oleg Nesterov
s member correctly. > > What do you think? Seriouly, how about the patch below? In fact, given that you are going to reimplement set_swbp/orig_insn, the new member is not strictly needed (afaics). But it looks more clear this way, and we need s/MAX_UINSN_BYTES/sizeof()/ anyway. Oleg. --- S

[PATCH] uprobes: introduce arch_uprobe-ixol

2013-11-04 Thread Oleg Nesterov
think? Seriouly, how about the patch below? In fact, given that you are going to reimplement set_swbp/orig_insn, the new member is not strictly needed (afaics). But it looks more clear this way, and we need s/MAX_UINSN_BYTES/sizeof()/ anyway. Oleg. --- Subject: [PATCH] uprobes: introduce

Re: [PATCH] uprobes: introduce arch_uprobe-ixol

2013-11-04 Thread David Long
On 11/04/13 14:49, Oleg Nesterov wrote: On 10/29, Oleg Nesterov wrote: David. Perhaps we can avoid the new hook altogether? What if we do the simple change below (it ignores powerpc) ? Then arm can add unsigned long ixol[2] into its arch_uprobe, and arch_uprobe_analyze_insn() can initialize