Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

2015-01-16 Thread Oliver Neukum
On Thu, 2015-01-15 at 17:47 -0600, Chris Rorvick wrote: > I think understand your comment now so I will respond more > specifically: > This is a typo precisely because `bNumEndpoint' is not consistent with > the specification, nor is it consistent with the definition of `struct >

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

2015-01-16 Thread Oliver Neukum
On Thu, 2015-01-15 at 17:47 -0600, Chris Rorvick wrote: I think understand your comment now so I will respond more specifically: This is a typo precisely because `bNumEndpoint' is not consistent with the specification, nor is it consistent with the definition of `struct

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

2015-01-15 Thread Chris Rorvick
On Thu, Jan 15, 2015 at 6:54 AM, Chris Rorvick wrote: > On Thu, Jan 15, 2015 at 5:03 AM, Oliver Neukum wrote: >> On Wed, 2015-01-14 at 21:52 -0600, Chris Rorvick wrote: >>> The descriptor member `bNumEndpoints' is plural. >> >> I am afraid that is not a good idea. The name of a >> member of a

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

2015-01-15 Thread Chris Rorvick
On Thu, Jan 15, 2015 at 5:03 AM, Oliver Neukum wrote: > On Wed, 2015-01-14 at 21:52 -0600, Chris Rorvick wrote: >> The descriptor member `bNumEndpoints' is plural. > > I am afraid that is not a good idea. The name of a > member of a structure mentioned in the specification should > appear as it

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

2015-01-15 Thread Oliver Neukum
On Wed, 2015-01-14 at 21:52 -0600, Chris Rorvick wrote: > The descriptor member `bNumEndpoints' is plural. I am afraid that is not a good idea. The name of a member of a structure mentioned in the specification should appear as it is used in the specification. Regards

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

2015-01-15 Thread Chris Rorvick
On Thu, Jan 15, 2015 at 6:54 AM, Chris Rorvick ch...@rorvick.com wrote: On Thu, Jan 15, 2015 at 5:03 AM, Oliver Neukum oneu...@suse.de wrote: On Wed, 2015-01-14 at 21:52 -0600, Chris Rorvick wrote: The descriptor member `bNumEndpoints' is plural. I am afraid that is not a good idea. The name

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

2015-01-15 Thread Oliver Neukum
On Wed, 2015-01-14 at 21:52 -0600, Chris Rorvick wrote: The descriptor member `bNumEndpoints' is plural. I am afraid that is not a good idea. The name of a member of a structure mentioned in the specification should appear as it is used in the specification. Regards

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

2015-01-15 Thread Chris Rorvick
On Thu, Jan 15, 2015 at 5:03 AM, Oliver Neukum oneu...@suse.de wrote: On Wed, 2015-01-14 at 21:52 -0600, Chris Rorvick wrote: The descriptor member `bNumEndpoints' is plural. I am afraid that is not a good idea. The name of a member of a structure mentioned in the specification should appear

[PATCH] usb: Fix typo in `struct usb_host_interface' comment

2015-01-14 Thread Chris Rorvick
The descriptor member `bNumEndpoints' is plural. Signed-off-by: Chris Rorvick --- include/linux/usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/usb.h b/include/linux/usb.h index f89c24a..4add566 100644 --- a/include/linux/usb.h +++ b/include/linux/usb.h

[PATCH] usb: Fix typo in `struct usb_host_interface' comment

2015-01-14 Thread Chris Rorvick
The descriptor member `bNumEndpoints' is plural. Signed-off-by: Chris Rorvick ch...@rorvick.com --- include/linux/usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/usb.h b/include/linux/usb.h index f89c24a..4add566 100644 --- a/include/linux/usb.h +++